All of lore.kernel.org
 help / color / mirror / Atom feed
From: tskd08@gmail.com
To: linux-media@vger.kernel.org
Cc: m.chehab@samsung.com, Akihiro Tsukada <tskd08@gmail.com>
Subject: [PATCH v2 6/7] v4l-utils/libdvbv5: don't discard config-supplied parameters
Date: Sun, 26 Oct 2014 20:46:22 +0900	[thread overview]
Message-ID: <1414323983-15996-7-git-send-email-tskd08@gmail.com> (raw)
In-Reply-To: <1414323983-15996-1-git-send-email-tskd08@gmail.com>

From: Akihiro Tsukada <tskd08@gmail.com>

When an user enabled the option to update parameters with PSI,
the parameters that were supplied from config file and  not mandatory
to the delivery system were discarded.
---
 lib/libdvbv5/dvb-fe.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/lib/libdvbv5/dvb-fe.c b/lib/libdvbv5/dvb-fe.c
index 05f7d03..52af4e4 100644
--- a/lib/libdvbv5/dvb-fe.c
+++ b/lib/libdvbv5/dvb-fe.c
@@ -575,6 +575,7 @@ int dvb_fe_get_parms(struct dvb_v5_fe_parms *p)
 	int i, n = 0;
 	const unsigned int *sys_props;
 	struct dtv_properties prop;
+	struct dtv_property fe_prop[DTV_MAX_COMMAND];
 	struct dvb_frontend_parameters v3_parms;
 	uint32_t bw;
 
@@ -583,19 +584,14 @@ int dvb_fe_get_parms(struct dvb_v5_fe_parms *p)
 		return EINVAL;
 
 	while (sys_props[n]) {
-		parms->dvb_prop[n].cmd = sys_props[n];
+		fe_prop[n].cmd = sys_props[n];
 		n++;
 	}
-	parms->dvb_prop[n].cmd = DTV_DELIVERY_SYSTEM;
-	parms->dvb_prop[n].u.data = parms->p.current_sys;
+	fe_prop[n].cmd = DTV_DELIVERY_SYSTEM;
+	fe_prop[n].u.data = parms->p.current_sys;
 	n++;
 
-	/* Keep it ready for set */
-	parms->dvb_prop[n].cmd = DTV_TUNE;
-	parms->n_props = n;
-
-	struct dtv_property fe_prop[DTV_MAX_COMMAND];
-	n = dvb_copy_fe_props(parms->dvb_prop, n, fe_prop);
+	n = dvb_copy_fe_props(fe_prop, n, fe_prop);
 
 	prop.props = fe_prop;
 	prop.num = n;
-- 
2.1.2


  parent reply	other threads:[~2014-10-26 11:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-26 11:46 [PATCH v2 0/7] v4l-utils/libdvbv5,dvb: add support for ISDB-S tskd08
2014-10-26 11:46 ` [PATCH v2 1/7] v4l-utils/libdvbv5: fix auto generation of channel names tskd08
2014-10-27 14:01   ` Mauro Carvalho Chehab
2014-10-27 14:31   ` Mauro Carvalho Chehab
2014-10-26 11:46 ` [PATCH v2 2/7] v4l-utils/libdvbv5: add support for ISDB-S tuning tskd08
2014-10-27 14:38   ` Mauro Carvalho Chehab
2014-10-26 11:46 ` [PATCH v2 3/7] v4l-utils/libdvbv5: add support for ISDB-S scanning tskd08
2014-10-27 14:46   ` Mauro Carvalho Chehab
2014-10-31 14:37     ` Akihiro TSUKADA
2014-10-31 19:53       ` Mauro Carvalho Chehab
2014-11-02  9:52         ` Akihiro TSUKADA
2014-10-26 11:46 ` [PATCH v2 4/7] v4l-utils/dvb: add COUNTRY property tskd08
2014-10-27 15:22   ` Mauro Carvalho Chehab
2014-10-26 11:46 ` [PATCH v2 5/7] v4l-utils/libdvbv5: add gconv module for the text translation of ISDB-S/T tskd08
2014-10-27 17:08   ` Mauro Carvalho Chehab
2014-10-31 15:02     ` Akihiro TSUKADA
2014-10-31 20:01       ` Mauro Carvalho Chehab
2014-10-26 11:46 ` tskd08 [this message]
2014-10-27 17:11   ` [PATCH v2 6/7] v4l-utils/libdvbv5: don't discard config-supplied parameters Mauro Carvalho Chehab
2014-10-31 15:24     ` Akihiro TSUKADA
2014-10-31 20:02       ` Mauro Carvalho Chehab
2014-10-26 11:46 ` [PATCH v2 7/7] v4l-utils/libdvbv5, dvbv5-scan: generalize channel duplication check tskd08
2014-10-27 17:14   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414323983-15996-7-git-send-email-tskd08@gmail.com \
    --to=tskd08@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.