From: Jiang Liu <jiang.liu@linux.intel.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
Yinghai Lu <yinghai@kernel.org>, Borislav Petkov <bp@alien8.de>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
x86@kernel.org
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Luck <tony.luck@intel.com>, Joerg Roedel <joro@8bytes.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-acpi@vger.kernel.org, rui.zhang@intel.com,
linux-pm@vger.kernel.org
Subject: [Patch v7 01/18] ACPI, irq: fix regression casued by 6b9fb7082409
Date: Mon, 27 Oct 2014 13:21:31 +0800 [thread overview]
Message-ID: <1414387308-27148-2-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1414387308-27148-1-git-send-email-jiang.liu@linux.intel.com>
When IOAPIC is disabled, acpi_gsi_to_irq() should return gsi directly
instead of calling mp_map_gsi_to_irq() to translate gsi to IRQ by IOAPIC.
It fixes https://bugzilla.kernel.org/show_bug.cgi?id=84381.
Reported-by: Thomas Richter <thor@math.tu-berlin.de>
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: rui.zhang@intel.com
Cc: <stable@vger.kernel.org> # 3.17
---
arch/x86/kernel/acpi/boot.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index b436fc735aa4..eceba9d9e116 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -604,14 +604,19 @@ void __init acpi_pic_sci_set_trigger(unsigned int irq, u16 trigger)
int acpi_gsi_to_irq(u32 gsi, unsigned int *irqp)
{
- int irq = mp_map_gsi_to_irq(gsi, IOAPIC_MAP_ALLOC | IOAPIC_MAP_CHECK);
+ int irq;
- if (irq >= 0) {
+ if (acpi_irq_model == ACPI_IRQ_MODEL_PIC) {
+ *irqp = gsi;
+ } else {
+ irq = mp_map_gsi_to_irq(gsi,
+ IOAPIC_MAP_ALLOC | IOAPIC_MAP_CHECK);
+ if (irq < 0)
+ return -1;
*irqp = irq;
- return 0;
}
- return -1;
+ return 0;
}
EXPORT_SYMBOL_GPL(acpi_gsi_to_irq);
--
1.7.10.4
next prev parent reply other threads:[~2014-10-27 5:21 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 5:21 [Patch v7 00/18] Enable support of IOAPIC hotplug on x86 platforms Jiang Liu
2014-10-27 5:21 ` Jiang Liu [this message]
2014-10-28 17:44 ` [Patch v7 01/18] ACPI, irq: fix regression casued by 6b9fb7082409 Pavel Machek
2014-10-28 18:13 ` Bjorn Helgaas
2014-10-28 18:45 ` Thomas Gleixner
2014-10-27 5:21 ` [Patch v7 02/18] x86, intel-mid: Create IRQs for APB timers and RTC timers Jiang Liu
2014-10-28 18:54 ` [tip:x86/urgent] " tip-bot for Jiang Liu
2014-10-29 9:10 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 03/18] ACPI, irq, x86: Return IRQ instead of GSI in mp_register_gsi() Jiang Liu
2014-10-28 18:54 ` [tip:x86/urgent] " tip-bot for Jiang Liu
2014-10-29 9:10 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 04/18] x86, PCI, ACPI: Kill private function resource_to_addr() in arch/x86/pci/acpi.c Jiang Liu
2014-11-03 10:57 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-11-03 14:50 ` Borislav Petkov
2014-12-10 4:08 ` Yinghai Lu
2014-12-10 13:36 ` Jiang Liu
2014-12-10 20:15 ` Thomas Gleixner
2014-12-11 0:31 ` Yinghai Lu
2014-12-11 0:35 ` Borislav Petkov
2014-12-11 1:57 ` Yinghai Lu
2014-12-11 4:13 ` Mike Galbraith
2014-12-11 7:42 ` Richard Cochran
2014-12-11 16:36 ` Thomas Gleixner
2014-12-11 16:57 ` Yinghai Lu
2014-12-11 16:37 ` Bjorn Helgaas
2014-10-27 5:21 ` [Patch v7 05/18] ACPI: Correct return value of acpi_dev_resource_address_space() Jiang Liu
2014-10-27 22:30 ` Rafael J. Wysocki
2014-10-27 22:49 ` Bjorn Helgaas
2014-10-27 23:11 ` Rafael J. Wysocki
2014-10-28 1:13 ` Bjorn Helgaas
2014-11-03 10:57 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-12-19 14:00 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 06/18] ACPI: Fix minor syntax issues in processor_core.c Jiang Liu
2014-11-03 10:58 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-12-19 14:02 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 07/18] ACPI: Add interfaces to parse IOAPIC ID for IOAPIC hotplug Jiang Liu
2014-11-03 10:58 ` [tip:x86/apic] " tip-bot for Yinghai Lu
2014-10-27 5:21 ` [Patch v7 08/18] PCI: Remove PCI ioapic driver Jiang Liu
2014-11-03 10:58 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-12-19 14:02 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 09/18] x86, irq: Split out alloc_ioapic_save_registers() Jiang Liu
2014-11-03 10:58 ` [tip:x86/apic] " tip-bot for Yinghai Lu
2014-12-19 14:03 ` tip-bot for Yinghai Lu
2014-10-27 5:21 ` [Patch v7 10/18] x86, irq: Prefer assigned ID in APIC ID register for x86_64 Jiang Liu
2014-11-03 10:59 ` [tip:x86/apic] " tip-bot for Yinghai Lu
2014-12-19 14:03 ` tip-bot for Yinghai Lu
2014-10-27 5:21 ` [Patch v7 11/18] x86, irq: Remove __init marker for functions will be used by IOAPIC hotplug Jiang Liu
2014-11-03 10:59 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-12-19 14:03 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 12/18] x86, irq: Keep balance of IOAPIC pin reference count Jiang Liu
2014-11-03 10:59 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-12-19 14:04 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 13/18] x86, irq: Refine mp_register_ioapic() to prepare for IOAPIC hotplug Jiang Liu
2014-11-03 11:00 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-12-19 14:04 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 14/18] x86, irq, ACPI: Introduce a rwsem to protect IOAPIC operations from hotplug Jiang Liu
2014-11-01 18:59 ` Thomas Gleixner
2014-11-02 5:24 ` Jiang Liu
2014-10-27 5:21 ` [Patch v7 15/18] x86, irq, ACPI: Implement interface to support ACPI based IOAPIC hot-addition Jiang Liu
2014-11-03 11:00 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-12-19 14:04 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 16/18] x86, irq, ACPI: Implement interfaces to support ACPI based IOAPIC hot-removal Jiang Liu
2014-11-03 11:00 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-12-19 14:05 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 17/18] x86, irq: Introduce helper to check whether an IOAPIC has been registered Jiang Liu
2014-10-28 17:47 ` Pavel Machek
2014-11-03 11:01 ` [tip:x86/apic] " tip-bot for Jiang Liu
2014-12-19 14:05 ` tip-bot for Jiang Liu
2014-10-27 5:21 ` [Patch v7 18/18] x86, irq, ACPI: Implement ACPI driver to support IOAPIC hotplug Jiang Liu
2014-11-03 11:01 ` [tip:x86/apic] " tip-bot for Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414387308-27148-2-git-send-email-jiang.liu@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.