From: Adam Jackson <ajax@redhat.com>
To: "Stéphane Marchesin" <stephane.marchesin@gmail.com>
Cc: Zach Reizner <zachr@google.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] allow 32bpp framebuffers for cirrus drm
Date: Mon, 27 Oct 2014 11:00:40 -0400 [thread overview]
Message-ID: <1414422040.15671.15.camel@dmt> (raw)
In-Reply-To: <CACP_E+JpB-24v1JkrDT1KANh9u+e-VNuupqF6gKGJmFhSDf7cA@mail.gmail.com>
On Fri, 2014-10-24 at 18:31 -0700, Stéphane Marchesin wrote:
> Dave, Adam: are you ok with this patch?
Seems like it doesn't go far enough? You'd already need an "aware"
guest to have this work, since the chip actually being emulated didn't
have 32bpp. The pitch check would prevent 1024x768x32 and larger from
working, which makes it sort of a weak win on its own.
Could we read the BAR size from the device instead of hardcoding 4M?
That alone would make 1920x1200x16 work; and then, if that pitch limit
isn't encoded into the register space representation, the aware guest
would have resolutions worth using at least be possible.
- ajax
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-10-27 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 19:49 [PATCH] allow 32bpp framebuffers for cirrus drm Zach Reizner
2014-10-25 1:31 ` Stéphane Marchesin
2014-10-27 15:00 ` Adam Jackson [this message]
2014-10-27 15:30 ` Gerd Hoffmann
2014-10-27 15:36 ` Zachary Reizner
2014-10-27 16:21 ` Adam Jackson
2014-10-27 22:09 ` Zachary Reizner
2014-10-28 9:09 ` Gerd Hoffmann
2014-10-28 17:04 ` Zachary Reizner
2014-10-29 11:00 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414422040.15671.15.camel@dmt \
--to=ajax@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=stephane.marchesin@gmail.com \
--cc=zachr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.