From: Joe Perches <joe@perches.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 03/11] aiptek: Fix probable mask then right shift defects
Date: Mon, 27 Oct 2014 11:03:51 -0700 [thread overview]
Message-ID: <1414433031.18896.2.camel@perches.com> (raw)
In-Reply-To: <3320721.qubDk7TkeJ@dtor-glaptop>
On Mon, 2014-10-27 at 11:01 -0700, Dmitry Torokhov wrote:
> On Monday, October 27, 2014 10:56:54 AM Joe Perches wrote:
> > On Mon, 2014-10-27 at 07:44 -0700, Dmitry Torokhov wrote:
> > > On Sun, Oct 26, 2014 at 10:24:59PM -0700, Joe Perches wrote:
> > > > Precedence of & and >> is not the same and is not left to right.
> > > > shift has higher precedence and should be done after the mask.
> > >
> > > Looking at the protocol description the current code is exactly right.
> > > We want to "move" button bits first as in packet type 1 they are in a
> > > different place than in other packets.
> > >
> > > I'll take a patch that adds parenthesis around shifts to make clear it
> > > is intended.
> >
> > I think it's more sensible to do the shift first to a
> > temporary then direct comparisons.
[]
> Unless you have the device I'd rather kept the changes (which are mostly
> cosmetic in nature and do not fix any bugs) to a minimum.
I don't have the device.
I think you should do what you think appropriate.
cheers, Joe
next prev parent reply other threads:[~2014-10-27 18:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 5:24 [PATCH 00/11] treewide: mask then shift defects and style updates Joe Perches
2014-10-27 5:24 ` Joe Perches
2014-10-27 5:24 ` Joe Perches
2014-10-27 5:24 ` [PATCH 01/11] block: nvme-scsi: Fix probable mask then right shift defects Joe Perches
2014-10-27 5:24 ` Joe Perches
2014-11-10 19:33 ` Verma, Vishal L
2014-11-10 19:33 ` Verma, Vishal L
2014-10-27 5:24 ` [PATCH 02/11] radeon: evergreen: " Joe Perches
2014-10-27 5:24 ` Joe Perches
2014-10-27 9:14 ` Michel Dänzer
2014-10-27 9:14 ` Michel Dänzer
2014-10-27 14:14 ` [PATCH 02/11 V2] radeon: evergreen: Fix probable mask then right shift defect Joe Perches
2014-10-27 14:14 ` Joe Perches
2014-10-28 3:42 ` Michel Dänzer
2014-10-28 3:42 ` Michel Dänzer
2014-10-28 14:06 ` Alex Deucher
2014-10-28 14:06 ` Alex Deucher
2014-10-29 3:03 ` Michel Dänzer
2014-10-29 3:03 ` Michel Dänzer
2014-10-27 5:24 ` [PATCH 03/11] aiptek: Fix probable mask then right shift defects Joe Perches
2014-10-27 14:44 ` Dmitry Torokhov
2014-10-27 17:56 ` Joe Perches
2014-10-27 18:01 ` Dmitry Torokhov
2014-10-27 18:03 ` Joe Perches [this message]
2014-10-27 5:25 ` [PATCH 04/11] dvb-net: " Joe Perches
2014-10-27 5:25 ` [PATCH 05/11] cx25840/cx18: Use standard ordering of mask and shift Joe Perches
2014-11-08 13:41 ` Andy Walls
2014-10-27 5:25 ` [PATCH 06/11] wm8350-core: Fix probable mask then right shift defect Joe Perches
2014-10-27 12:47 ` Charles Keepax
2014-11-03 18:02 ` Lee Jones
2014-10-27 5:25 ` [PATCH 07/11] iwlwifi: dvm: " Joe Perches
2014-10-27 6:14 ` Grumbach, Emmanuel
2014-10-27 5:25 ` [PATCH 08/11] ssb: driver_chip_comon_pmu: " Joe Perches
2014-10-27 17:32 ` Michael Büsch
2014-10-27 5:25 ` [PATCH 09/11] tty: ipwireless: Fix probable mask then right shift defects Joe Perches
2014-10-27 13:18 ` David Sterba
2014-10-27 14:17 ` Jiri Kosina
2014-10-28 1:57 ` Greg Kroah-Hartman
2014-10-27 5:25 ` [PATCH 10/11] hwa-hc: Fix probable mask then right shift defect Joe Perches
2014-10-27 5:25 ` [PATCH 11/11] sound: ad1889: Fix probable mask then right shift defects Joe Perches
2014-10-27 7:41 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414433031.18896.2.camel@perches.com \
--to=joe@perches.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.