From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: Sanity check input and serialize vcpu data in sched_rt.c Date: Wed, 29 Oct 2014 11:06:26 +0100 Message-ID: <1414577186.20696.52.camel@Abyss> References: <1414246599-3914-1-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4476356276234746291==" Return-path: In-Reply-To: <1414246599-3914-1-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Meng Xu Cc: george.dunlap@eu.citrix.com, "konrad.r.wilk" , xumengpanda@gmail.com, JBeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============4476356276234746291== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-WauyrxvXe0ITO779bpkP" --=-WauyrxvXe0ITO779bpkP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2014-10-25 at 10:16 -0400, Meng Xu wrote: > These two patches are to solve the issues found by Jan Beulich at http://= lists.xen.org/archives/html/xen-devel/2014-09/msg03554.html. >=20 > The solution is summarized by Dario Faggioli at http://lists.xen.org/arch= ives/html/xen-devel/2014-09/msg03603.html. >=20 > Here is the solution: > - sanity checking input params in rt_dom_cntl() > - serialize rt_dom_cntl() itself against the global lock > - move the call to rt_update_deadline() from _alloc to _insert >=20 Ok, thanks Meng for the patches, and for this summary. I've already reviewed the patches, and they look fine to me. If I can add a few things about the submission: - threading is ok this time, good job with that :-D - cover letter subject summarizes properly the series content, but=20 should contain the [PATCH xxx xxx] prefix as regular patches, as if it were patch 0 of the series - since this is v2, it is really useful to include, in each patch, a quick summary of what changed wrt previous version. You usually do it in the changelog of each patch itself, after a "---" mark, below the Signed-off and similar tags Finally, since we're in freeze, we should 'convince' Konrad that these patches really need to be merged right now, instead of waiting for 4.6. See Konrad's development update emails for more details. About that, Konrad, my take is as follows: - this is a bugfix, so, always a good one to have :-) - this only touches the new scheduler's code, with basically zero chances of causing issues to others - the new scheduler is marked as experimental So, yes, I think these patches should be considered for 4.5 Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-WauyrxvXe0ITO779bpkP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlRQvCIACgkQk4XaBE3IOsRCLQCfSHvDzZjT9XPFXgCLi070KqPa D8IAn0Rll+Xm37l4PJRJMDoPYLGhCH5h =yziM -----END PGP SIGNATURE----- --=-WauyrxvXe0ITO779bpkP-- --===============4476356276234746291== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4476356276234746291==--