From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH for-4.5] xen/common: Process softirqs while
 dumping domains
Date: Wed, 29 Oct 2014 18:11:33 +0100
Message-ID: <1414602693.20696.63.camel@Abyss>
References: <1414595326-14257-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3452653735259785839=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1414595326-14257-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============3452653735259785839==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-DmEjgaV5I04N7GeNWCsd"

--=-DmEjgaV5I04N7GeNWCsd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2014-10-29 at 15:08 +0000, Andrew Cooper wrote:
> Process softirqs once per domain, and once every 64 vcpus in a guest to a=
void
> being hit by the NMI watchdog.  Discovered against a VM which had acciden=
tally
> been assigned 8192 vcpus.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Personally...

> diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
> index 809378c..c9d9206 100644
> --- a/xen/common/keyhandler.c
> +++ b/xen/common/keyhandler.c

> @@ -287,6 +290,9 @@ static void dump_domains(unsigned char key)
>                 d->domain_id);
>          for_each_vcpu ( d, v )
>          {
> +            if ( (v->vcpu_id & 0x3f) =3D=3D 0 )
> +                process_pending_softirqs();
> +
>
... I think something like ( vcpu_id % 64 ) would have been more
readable, but I understand that's only a matter of taste. :-)

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-DmEjgaV5I04N7GeNWCsd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlRRH8UACgkQk4XaBE3IOsT8TQCfUFye2WfBWfQZVmlEIuLG496q
PsoAnRgwJyruNljRyEFBcmCdk1sjyeOG
=Ipfa
-----END PGP SIGNATURE-----

--=-DmEjgaV5I04N7GeNWCsd--


--===============3452653735259785839==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3452653735259785839==--