From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [OPW PATCH] tools/xl: Call init function for libxl_bitmap Date: Wed, 29 Oct 2014 18:52:44 +0100 Message-ID: <1414605164.20696.71.camel@Abyss> References: <5443cfde.0286440a.434c.1100@mx.google.com> <20141020152326.GH19994@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1899225638081554992==" Return-path: In-Reply-To: <20141020152326.GH19994@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: George.Dunlap@eu.citrix.com, Ian.Jackson@citrix.com, xen-devel@lists.xen.org, Ian Campbell , Uma Sharma List-Id: xen-devel@lists.xenproject.org --===============1899225638081554992== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-EgNCluw+AM5YCMG8MQov" --=-EgNCluw+AM5YCMG8MQov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2014-10-20 at 16:23 +0100, Wei Liu wrote: > On Sun, Oct 19, 2014 at 08:21:01PM +0530, Uma Sharma wrote: > > This patch calls init function for libxl_bitmap in > > main_cpupoolnumasplit() and vcpuset() > > tools/libxl/xl_cmdimpl.c > > IDL generated libxl types should be used only after calling the init > > function even if the variable is simply being passed by reference as > > an output parameter to a libxl function > >=20 > > Signed-off-by: Uma Sharma >=20 > Acked-by: Wei Liu > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > > @@ -4843,7 +4843,8 @@ static void vcpuset(uint32_t domid, const char* n= r_vcpus, int check_host) > > char *endptr; > > unsigned int max_vcpus, i; > > libxl_bitmap cpumap; > > - > > + =20 > > + libxl_bitmap_init(&cpumap); > This is introducing some white space damaging, IMO. In fact, it seems you are removing a black line, i.e., a line which was *totally* empty, as it should be, with one which has _only_ 4 white spaces. That's kind of common while working on patches, I know, but it's not what we want. To avoid sending patches suffering from this issue, you certainly can configure your editor to properly deal with the Xen coding style. What I also find really useful is that, if looking at the patch with `git show' or `stg show', the trailing white spaces are marked in red (yes, you probably need to configure git for that, but, if you're lucky, that's already the default for your dev environment). > > @@ -7254,7 +7255,8 @@ int main_cpupoolnumasplit(int argc, char **argv) > > } > > =20 > > ret =3D 0; > > - > > + =20 > > + libxl_bitmap_init(&cpumap); > Same here. TBH, I'm a bit confused, and am not sure if this is the actual latest version of this patch. If it's not, sorry for the noise. Regards, Dario > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-EgNCluw+AM5YCMG8MQov Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlRRKWwACgkQk4XaBE3IOsTyegCfadRmpp8z7cOXU2WKiEig5H0x p44AoJW4VQt4TKaoKSN7Yq2y0m1kNmVl =EFzx -----END PGP SIGNATURE----- --=-EgNCluw+AM5YCMG8MQov-- --===============1899225638081554992== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1899225638081554992==--