Re: [PATCH] Valgrind: Remove test apps not building with ppc64 and PTEST

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2014-10-30 at 17:46 +0100, Alexandra Safta wrote:
> Signed-off-by: Alexandra Safta <alexandra.safta@enea.com>

This removes the tests for all architectures? Why is that a good idea?
At the very least this needs more explanation.

Cheers,

Richard




>  .../valgrind/remove-ppc64-tests-failing-build.patch      | 16 ++++++++++++++++
>  meta/recipes-devtools/valgrind/valgrind_3.9.0.bb         |  3 ++-
>  2 files changed, 18 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-devtools/valgrind/valgrind/remove-ppc64-tests-failing-build.patch
> 
> diff --git a/meta/recipes-devtools/valgrind/valgrind/remove-ppc64-tests-failing-build.patch b/meta/recipes-devtools/valgrind/valgrind/remove-ppc64-tests-failing-build.patch
> new file mode 100644
> index 0000000..7bf3a21
> --- /dev/null
> +++ b/meta/recipes-devtools/valgrind/valgrind/remove-ppc64-tests-failing-build.patch
> @@ -0,0 +1,16 @@
> +--- a/none/tests/ppc64/Makefile.am	2014-10-22 16:33:20.686773392 +0200
> ++++ b/none/tests/ppc64/Makefile.am	2014-10-23 10:31:38.948654523 +0200
> +@@ -35,11 +35,10 @@
> +
> + check_PROGRAMS = \
> + 	allexec \
> +-	jm-insns lsw round std_reg_imm twi_tdi tw_td power6_bcmp \
> ++	lsw round std_reg_imm twi_tdi tw_td power6_bcmp \
> + 	power6_mf_gpr test_isa_2_06_part1 test_isa_2_06_part2 \
> + 	test_isa_2_06_part3 test_dfp1 test_dfp2 test_dfp3 test_dfp4 \
> +-	test_dfp5 test_isa_2_07_part1 test_isa_2_07_part2 \
> +-	test_tm test_touch_tm
> ++	test_dfp5
> +
> + AM_CFLAGS    += @FLAG_M64@
> + AM_CXXFLAGS  += @FLAG_M64@
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb
> index c415e77..f642856 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb
> @@ -19,6 +19,7 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>             file://force-nostabs.patch \
>             file://remove-arm-variant-specific.patch \
>             file://remove-ppc-tests-failing-build.patch \
> +           file://remove-ppc64-tests-failing-build.patch \
>             file://add-ptest.patch \
>             file://run-ptest \
>            "
> @@ -63,7 +64,7 @@ do_install_ptest() {
>      #
>      # The regression tests require scripts and data files that are not
>      # copied to the build directory.  They must be copied from the
> -    # source directory.
> +    # source directory.
>      saved_dir=$PWD
>      for parent_dir in ${S} ${B} ; do
>          cd $parent_dir
> --
> 1.9.1
>