Re: [PATCH 1/2] cfg80211: 802.11p OCB mode handling

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2014-10-31 at 16:12 +0100, Rostislav Lisovy wrote:
> On Fri, 2014-10-31 at 14:13 +0100, Johannes Berg wrote:
> > On Thu, 2014-10-30 at 11:42 +0100, Rostislav Lisovy wrote:
> > > @@ -2093,6 +2102,7 @@ enum nl80211_iftype {
> > >  	NL80211_IFTYPE_P2P_CLIENT,
> > >  	NL80211_IFTYPE_P2P_GO,
> > >  	NL80211_IFTYPE_P2P_DEVICE,
> > > +	NL80211_IFTYPE_OCB,
> > 
> > This is causing a bunch of compiler warnings (warning: enumeration value
> > ‘NL80211_IFTYPE_OCB’ not handled in switch, e.g. in mac80211/iface.c)
> > which I think you should address in this patch. That'll mean that you
> > modify even mac80211 and potentially some drivers, but I think that's
> > the right thing to do in this patch since it's the one changing the API
> > to introduce the new value.
> 
> I was aware of the warnings but thought this is the chicken-egg problem
> which can't be solved properly.
> Fortunately there is no driver affected.

Yeah I checked the drivers after sending the mail :)

I think you can add dummy "case OCB" statements to mac80211 in this
patch, and then overwrite them with proper code in the next one. I'd
like to have the build warning-free for every commit, if at all
possible.

johannes