From: Chen Weixiang <weixiangchen@gmail.com>
To: Marek Belisko <marek.belisko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chen Weixiang <weixiang.chen@gmail.com>,
Aybuke Ozdemir <aybuke.147@gmail.com>,
Felipe Balbi <balbi@ti.com>, Nicolas Thery <nthery@gmail.com>,
Greg Donald <gdonald@gmail.com>,
Daniel Dodge <danieldodgese@gmail.com>,
Wilfried Klaebe <w-lkml@lebenslange-mailadresse.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='
Date: Sat, 1 Nov 2014 10:47:22 +0800 [thread overview]
Message-ID: <1414810047-6975-2-git-send-email-weixiang.chen@gmail.com> (raw)
In-Reply-To: <1414810047-6975-1-git-send-email-weixiang.chen@gmail.com>
Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c
and ft1000/ft1000-pcmcia/ft1000_hw.c:
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
Signed-off-by: Chen Weixiang <weixiang.chen@gmail.com>
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 6 ++---
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 28 ++++++++++++------------
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
index 44575c7..fc28dee 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
@@ -812,11 +812,11 @@ static void ft1000_send_cmd (struct net_device *dev, u16 *ptempbuffer, int size,
/* Make sure SLOWQ doorbell is clear */
tempword = ft1000_read_reg(dev, FT1000_REG_DOORBELL);
- i=0;
+ i = 0;
while (tempword & FT1000_DB_DPRAM_TX) {
mdelay(10);
i++;
- if (i==10) {
+ if (i == 10) {
spin_unlock_irqrestore(&info->dpram_lock, flags);
return;
}
@@ -1221,7 +1221,7 @@ static void ft1000_proc_drvmsg(struct net_device *dev)
ppseudo_hdr->portsrc = 0;
/* Calculate new checksum */
ppseudo_hdr->checksum = *pmsg++;
- for (i=1; i<7; i++) {
+ for (i = 1; i < 7; i++) {
ppseudo_hdr->checksum ^= *pmsg++;
}
pmsg = (u16 *) & tempbuffer[16];
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
index 0f347ab..02bfb3e 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
@@ -193,7 +193,7 @@ int ft1000_create_dev(struct ft1000_usb *dev)
/* initialize application information */
dev->appcnt = 0;
- for (i=0; i<MAX_NUM_APP; i++) {
+ for (i = 0; i < MAX_NUM_APP; i++) {
dev->app_info[i].nTxMsg = 0;
dev->app_info[i].nRxMsg = 0;
dev->app_info[i].nTxMsgReject = 0;
@@ -260,7 +260,7 @@ void ft1000_destroy_dev(struct net_device *netdev)
dev->DeviceName);
/* Make sure we free any memory reserve for slow Queue */
- for (i=0; i<MAX_NUM_APP; i++) {
+ for (i = 0; i < MAX_NUM_APP; i++) {
while (list_empty(&dev->app_info[i].app_sqlist) == 0) {
pdpram_blk = list_entry(dev->app_info[i].app_sqlist.next, struct dpram_blk, list);
list_del(&pdpram_blk->list);
@@ -318,7 +318,7 @@ static int ft1000_open(struct inode *inode, struct file *file)
}
/* Search for available application info block */
- for (i=0; i<MAX_NUM_APP; i++) {
+ for (i = 0; i < MAX_NUM_APP; i++) {
if ((dev->app_info[i].fileobject == NULL)) {
break;
}
@@ -369,7 +369,7 @@ static unsigned int ft1000_poll_dev(struct file *file, poll_table *wait)
}
/* Search for matching file object */
- for (i=0; i<MAX_NUM_APP; i++) {
+ for (i = 0; i < MAX_NUM_APP; i++) {
if (dev->app_info[i].fileobject == &file->f_owner) {
/* DEBUG("FT1000:ft1000_ioctl: Message is for AppId = %d\n", dev->app_info[i].app_id); */
break;
@@ -411,7 +411,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
void __user *argp = (void __user *)argument;
struct ft1000_info *info;
struct ft1000_usb *ft1000dev;
- int result=0;
+ int result = 0;
int cmd;
int i;
u16 tempword;
@@ -426,8 +426,8 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
0x00,0x00,0x02,0x37,0x00,0x00,0x00,0x08,0x00,0x00,0x00,0x01,0x00,0x01,0x7f,0x00,
0x00,0x01,0x00,0x00};
- unsigned short ledStat=0;
- unsigned short conStat=0;
+ unsigned short ledStat = 0;
+ unsigned short conStat = 0;
/* DEBUG("ft1000_ioctl called\n"); */
@@ -454,7 +454,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
}
if (tempword == DSPBCMSGID) {
/* Search for matching file object */
- for (i=0; i<MAX_NUM_APP; i++) {
+ for (i = 0; i < MAX_NUM_APP; i++) {
if (ft1000dev->app_info[i].fileobject == &file->f_owner) {
ft1000dev->app_info[i].DspBCMsgFlag = 1;
DEBUG("FT1000:ft1000_ioctl:Registered for broadcast messages\n");
@@ -581,12 +581,12 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
result = -EFAULT;
} else {
/* Check if this message came from a registered application */
- for (i=0; i<MAX_NUM_APP; i++) {
+ for (i = 0; i < MAX_NUM_APP; i++) {
if (ft1000dev->app_info[i].fileobject == &file->f_owner) {
break;
}
}
- if (i==MAX_NUM_APP) {
+ if (i == MAX_NUM_APP) {
DEBUG("FT1000:No matching application fileobject\n");
result = -EINVAL;
kfree(dpram_data);
@@ -646,7 +646,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
/* Calculate new checksum */
ppseudo_hdr->checksum = *pmsg++;
/* DEBUG("checksum = 0x%x\n", ppseudo_hdr->checksum); */
- for (i=1; i<7; i++) {
+ for (i = 1; i < 7; i++) {
ppseudo_hdr->checksum ^= *pmsg++;
/* DEBUG("checksum = 0x%x\n", ppseudo_hdr->checksum); */
}
@@ -682,7 +682,7 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
}
/* Search for matching file object */
- for (i=0; i<MAX_NUM_APP; i++) {
+ for (i = 0; i < MAX_NUM_APP; i++) {
if (ft1000dev->app_info[i].fileobject == &file->f_owner) {
/*DEBUG("FT1000:ft1000_ioctl: Message is for AppId = %d\n", ft1000dev->app_info[i].app_id); */
break;
@@ -766,14 +766,14 @@ static int ft1000_release(struct inode *inode, struct file *file)
}
/* Search for matching file object */
- for (i=0; i<MAX_NUM_APP; i++) {
+ for (i = 0; i < MAX_NUM_APP; i++) {
if (ft1000dev->app_info[i].fileobject == &file->f_owner) {
/* DEBUG("FT1000:ft1000_ioctl: Message is for AppId = %d\n", ft1000dev->app_info[i].app_id); */
break;
}
}
- if (i==MAX_NUM_APP)
+ if (i == MAX_NUM_APP)
return 0;
while (list_empty(&ft1000dev->app_info[i].app_sqlist) == 0) {
--
2.1.2
next prev parent reply other threads:[~2014-11-01 2:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 2:47 [PATCH v2 0/6] Remove checkpatch.pl errors from drivers/staging/ft1000 Chen Weixiang
2014-11-01 2:47 ` Chen Weixiang [this message]
2014-11-01 5:05 ` [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '==' Sudip Mukherjee
2014-11-01 5:14 ` Joe Perches
2014-11-01 5:25 ` Sudip Mukherjee
2014-11-01 5:30 ` Sudip Mukherjee
2014-11-01 5:47 ` Sudip Mukherjee
2014-11-01 14:51 ` Chen Weixiang
2014-11-01 14:09 ` Chen Weixiang
2014-11-01 16:29 ` Sudip Mukherjee
2014-11-04 0:05 ` Greg Kroah-Hartman
2014-11-10 0:16 ` Chen Weixiang
2014-11-10 1:00 ` Chen Weixiang
2014-11-01 2:47 ` [PATCH v2 2/6] staging: ft1000: space prohibited after '(', '&' and before ')' Chen Weixiang
2014-11-01 5:08 ` Sudip Mukherjee
2014-11-01 2:47 ` [PATCH v2 3/6] staging: ft1000: "(foo*)" should be "(foo *)" Chen Weixiang
2014-11-01 5:10 ` Sudip Mukherjee
2014-11-01 2:47 ` [PATCH v2 4/6] staging: ft1000: "foo * bar" should be "foo *bar" Chen Weixiang
2014-11-01 2:47 ` [PATCH v2 5/6] staging: ft1000: else should follow close brace '}' Chen Weixiang
2014-11-01 5:12 ` Sudip Mukherjee
2014-11-01 2:47 ` [PATCH v2 6/6] staging: ft1000: space required after that ',' Chen Weixiang
2014-11-01 5:13 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414810047-6975-2-git-send-email-weixiang.chen@gmail.com \
--to=weixiangchen@gmail.com \
--cc=aybuke.147@gmail.com \
--cc=balbi@ti.com \
--cc=danieldodgese@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=nthery@gmail.com \
--cc=w-lkml@lebenslange-mailadresse.de \
--cc=weixiang.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.