From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 03/10] xen/arm: Define quirk for Hip04 GICv2 divergence Date: Mon, 3 Nov 2014 13:54:51 +0000 Message-ID: <1415022891.24785.9.camel@citrix.com> References: <1415009522-6344-1-git-send-email-frediano.ziglio@huawei.com> <1415009522-6344-4-git-send-email-frediano.ziglio@huawei.com> <54578814.3060605@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54578814.3060605@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Frediano Ziglio , Tim Deegan , Stefano Stabellini , zoltan.kiss@huawei.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2014-11-03 at 13:50 +0000, Julien Grall wrote: > Actually you use the quirk to do hisilicon specific (mostly in patch > #6). I would rename the quirk to show it's platform specific, something > like: > > PLATFORM_QUIRK_HISILICON_GICV2 or PLATFROM_QUIRK_HISILICON_GICV2_16_CPU. I think this should be keyed of the DT compatible string, since there is one, it's not really a quirk, it's essentially implementing a different hardware spec. Ian.