From: Joe Perches <joe@perches.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ALSA: echoaudio: add reference of struct echoaudio
Date: Mon, 03 Nov 2014 09:45:47 -0800 [thread overview]
Message-ID: <1415036747.17743.24.camel@perches.com> (raw)
In-Reply-To: <20141103165243.GA7562@sudip-PC>
On Mon, 2014-11-03 at 22:22 +0530, Sudip Mukherjee wrote:
> On Mon, Nov 03, 2014 at 07:08:08AM -0800, Joe Perches wrote:
[]
> > ftrace exists and is generic.
> >
> > Several of these seem to be function tracing
> > style uses and should just be deleted instead.
>
> function tracing style uses means?
ftrace
see:
Documentation/trace/ftrace.txt
Documentation/trace/ftrace-design.txt
> there are some prints which are printing the function name while printing the debug message.
> are those function tracing style uses??
A debug message should generally not be emitting a
message just for the sake of documenting when a
function is entered/left.
Sometimes that is useful for initial debugging, but
almost always those debugging printks should not be
left in the code that is pushed to kernel.org.
prev parent reply other threads:[~2014-11-03 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 10:34 [PATCH v2 1/2] ALSA: echoaudio: add reference of struct echoaudio Sudip Mukherjee
2014-11-03 10:34 ` Sudip Mukherjee
2014-11-03 10:34 ` [PATCH v2 2/2] ALSA: echoaudio: remove all snd_printk Sudip Mukherjee
2014-11-03 14:17 ` [PATCH v2 1/2] ALSA: echoaudio: add reference of struct echoaudio Takashi Iwai
2014-11-03 15:08 ` Joe Perches
2014-11-03 15:18 ` Takashi Iwai
2014-11-03 16:52 ` Sudip Mukherjee
2014-11-03 17:45 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415036747.17743.24.camel@perches.com \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.