From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] stmmac: remove custom implementation of print_hex_dump() Date: Mon, 03 Nov 2014 10:11:43 -0800 Message-ID: <1415038303.17743.27.camel@perches.com> References: <1415035734-24163-1-git-send-email-andriy.shevchenko@linux.intel.com> <1415035734-24163-2-git-send-email-andriy.shevchenko@linux.intel.com> <1415036355.17743.22.camel@perches.com> <1415037237.472.1.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Giuseppe Cavallaro , netdev@vger.kernel.org, Kweh Hock Leong , "David S . Miller" , Vince Bridgers To: Andy Shevchenko Return-path: Received: from smtprelay0023.hostedemail.com ([216.40.44.23]:59607 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753947AbaKCSLs (ORCPT ); Mon, 3 Nov 2014 13:11:48 -0500 In-Reply-To: <1415037237.472.1.camel@linux.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2014-11-03 at 19:53 +0200, Andy Shevchenko wrote: > On Mon, 2014-11-03 at 09:39 -0800, Joe Perches wrote: > > On Mon, 2014-11-03 at 19:28 +0200, Andy Shevchenko wrote: > > > There is a kernel helper to dump buffers in a hexdecimal format. This patch > > > substitutes the open coded function by calling that helper. > > [] > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > [] > > > @@ -191,14 +191,8 @@ static void stmmac_clk_csr_set(struct stmmac_priv *priv) > > > > > > static void print_pkt(unsigned char *buf, int len) > > > { > > > - int j; > > > - pr_debug("len = %d byte, buf addr: 0x%p", len, buf); > > > - for (j = 0; j < len; j++) { > > > - if ((j % 16) == 0) > > > - pr_debug("\n %03x:", j); > > > - pr_debug(" %02x", buf[j]); > > > - } > > > - pr_debug("\n"); > > > + pr_debug("len = %d byte, buf addr: 0x%p\n", len, buf); > > > + print_hex_dump(KERN_DEBUG, " ", DUMP_PREFIX_OFFSET, 16, 1, buf, len, 0); > > > > Prefix should be "" > > Oh, initially there is an indentation in one space. > Maybe Giuseppe would comment on this. I think that's not particularly important. This changes the output anyway as the the printed offset is now 8 chars wide not 3. > > Another (better?) option would be to use: > > > > print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len); > > > so that it can be dynamically controlled like > > the pr_debug statements. > > Ah, yes, but unfortunately it will print ASCII part always. Giuseppe, > what do you think? I'm not bothered by logging message output changes. It's not a guaranteed stable output. > P.S. [off topic] Joe, just would like to know if you have you seen my > last version of the patch series against hexdump.c which adds > seq_hex_dump() call [1]. If so, could you comment on it? > [1] https://lkml.org/lkml/2014/9/4/309 seq_ output however is guaranteed. So any conversion to the seq_hex_dump function would need to be exactly the same. New code could use seq_hex_dump. Other than that, it seems sensible enough.