All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Roberto Medina <robertoxmed@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: eth: realtek: atp: checkpatch errors and warnings corrected
Date: Mon, 03 Nov 2014 10:51:26 -0800	[thread overview]
Message-ID: <1415040686.17743.31.camel@perches.com> (raw)
In-Reply-To: <1415039073-20164-1-git-send-email-robertoxmed@gmail.com>

On Mon, 2014-11-03 at 19:24 +0100, Roberto Medina wrote:
> From: Roberto Medina <robertoxmed@gmail.com>
> 
> Several warnings and errors corrected using checkpatch.
> Some warnings like "line over 80" are still present.
> 
> Before the patch:
> 	total: 16 errors, 155 warnings, 38 checks, 883 lines checked
> 
> With the patch:
> 	total: 0 errors, 64 warnings, 24 checks, 905 lines checked
> 	
> Compile tested.

Some ancient drivers could be regarded as neolithic
curiosities that never need updating.  This may be one.

But if you really want to change it, could you please
make sure that objdiff shows no changes?



  reply	other threads:[~2014-11-03 18:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03 18:24 [PATCH] net: eth: realtek: atp: checkpatch errors and warnings corrected Roberto Medina
2014-11-03 18:51 ` Joe Perches [this message]
2014-11-03 19:09   ` Roberto Medina
2014-11-04 10:19     ` David Laight
2014-11-05  7:44       ` Roberto Medina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415040686.17743.31.camel@perches.com \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robertoxmed@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.