From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Marek Belisko <marek.belisko@gmail.com>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH V2 2/2] ASoC: staging: ft1000: Logging message neatening
Date: Mon, 03 Nov 2014 18:21:02 -0800 [thread overview]
Message-ID: <1415067662.17743.43.camel@perches.com> (raw)
In-Reply-To: <20141104003613.GA5128@kroah.com>
On Mon, 2014-11-03 at 16:36 -0800, Greg Kroah-Hartman wrote:
> On Mon, Nov 03, 2014 at 04:25:44PM -0800, Joe Perches wrote:
> > Use a more common logging style.
> >
> > o Convert DEBUG macros to pr_debug
> > o Add pr_fmt
> > o Remove embedded function names from pr_debug
> > o Convert printks to pr_<level>
> > o Coalesce formats and align arguments
> > o Add missing terminating newlines
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> ASoC???
>
> I'll go edit that by hand...
How odd. It must be some git weirdness I don't understand.
That's just from doing: (after a git pull of your staging-next tree)
$ patch -p1 < ../next/patches/ft1000/0001-staging-ft1000-Whitespace-neatening.patch
$ emacs drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c.rej
$ git commit -s drivers/staging/ft1000
$ git am ../next/patches/ft1000/0002-staging-ft1000-Logging-message-neatening.patch
$ git format-patch -2 --subject-prefix="PATCH V2" -o patches/ft1000 --cover-letter
I didn't touch either output patch but did edit the cover letter.
and ../next/patches/ft1000/0002-etc... doesn't have ASoC in it.
$ grep -i asoc ../next/patches/ft1000/0002-staging-ft1000-Logging-message-neatening.patch
$
next prev parent reply other threads:[~2014-11-04 2:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 23:53 [PATCH 0/2] staging: ft1000: generic neatening Joe Perches
2014-11-01 23:53 ` [PATCH 1/2] staging: ft1000: Whitespace neatening Joe Perches
2014-11-04 0:06 ` Greg Kroah-Hartman
2014-11-04 0:25 ` [PATCH V2 0/2] staging: ft1000: generic neatening Joe Perches
2014-11-04 0:25 ` [PATCH V2 1/2] staging: ft1000: Whitespace neatening Joe Perches
2014-11-04 0:25 ` [PATCH V2 2/2] ASoC: staging: ft1000: Logging message neatening Joe Perches
2014-11-04 0:36 ` Greg Kroah-Hartman
2014-11-04 2:21 ` Joe Perches [this message]
2014-11-01 23:53 ` [PATCH 2/2] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415067662.17743.43.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.