From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5] tools/pygrub: Fix TOCTOU race introduced by c/s 63dcc68 Date: Tue, 4 Nov 2014 10:48:02 +0000 Message-ID: <1415098082.11486.19.camel@citrix.com> References: <1414591781-19376-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1414591781-19376-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Wei Liu , Olaf Hering , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org On Wed, 2014-10-29 at 14:09 +0000, Andrew Cooper wrote: > In addition, use os.makedirs() which will also create intermediate directories > if they don't exist. > > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > CC: Konrad Rzeszutek Wilk > CC: Olaf Hering Acked and applied as a bug fix. In the future when you include a "for-4.5" tag on a patch please *always* state your reasoning (usually after the "---"). Don't make the maintainer / release manager / committer guess why you think it should be in 4.5. If you consider it "obviously a bug fix" then say so and then say something about the impact of the bug and the risk associated with the fix. I'm a bit grumpy about the number of patches which don't do this, such patches are mostly going to the back of my queue, alongside the 4.6 patches, since without any rationale that is effectively what I consider them to be despite the use of the for-4.5 tag. Ian.