From: Ian Campbell <Ian.Campbell@citrix.com>
To: Martin Pohlack <mpohlack@amazon.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] blktap: CONFIG_GCRYPT detection
Date: Tue, 4 Nov 2014 10:48:25 +0000 [thread overview]
Message-ID: <1415098105.11486.20.camel@citrix.com> (raw)
In-Reply-To: <1414499721-1100-1-git-send-email-mpohlack@amazon.de>
On Tue, 2014-10-28 at 13:35 +0100, Martin Pohlack wrote:
> Wrap make variable in () to allow correct evaluation.
>
> This fixes broken CONFIG_GCRYPT detection which was introduced by
> commit 85896a7c4dc7b6b1dba2db79dfb0ca61738a92a4 in 2012.
>
> Signed-off-by: Martin Pohlack <mpohlack@amazon.de>
> Reviewed-by: Uwe Dannowski <uwed@amazon.de>
> Reviewed-by: Anthony Liguori <aliguori@amazon.com>
> Reviewed-by: Matt Wilson <msw@amazon.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
You didn't mention if you considered this 4.5 material, but I think it
is a pretty obvious/safe bugfix so I've applied it.
> ---
> tools/blktap/drivers/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/blktap/drivers/Makefile b/tools/blktap/drivers/Makefile
> index 7461a95..cea8b3b 100644
> --- a/tools/blktap/drivers/Makefile
> +++ b/tools/blktap/drivers/Makefile
> @@ -11,7 +11,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
> CFLAGS += $(CFLAGS_libxenstore)
> CFLAGS += -D_GNU_SOURCE
>
> -ifeq ($CONFIG_GCRYPT,y)
> +ifeq ($(CONFIG_GCRYPT),y)
> CFLAGS += -DUSE_GCRYPT
> CRYPT_LIB := -lgcrypt
> else
prev parent reply other threads:[~2014-11-04 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 12:35 [PATCH] blktap: CONFIG_GCRYPT detection Martin Pohlack
2014-11-04 10:48 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415098105.11486.20.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=mpohlack@amazon.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.