From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] libxl: a domain can be dying but not
 shutdown
Date: Tue, 4 Nov 2014 10:48:44 +0000
Message-ID: <1415098124.11486.21.camel@citrix.com>
References: <1413985962-31909-1-git-send-email-dave.scott@citrix.com>
	<5447BA71.9030405@citrix.com> <1414057369.19198.28.camel@citrix.com>
	<5448D1C2.9050700@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XlbfN-0005qv-69
	for xen-devel@lists.xenproject.org; Tue, 04 Nov 2014 10:48:49 +0000
In-Reply-To: <5448D1C2.9050700@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: David Scott <dave.scott@citrix.com>, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, rob.hoes@citrix.com, euan.harris@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-10-23 at 11:00 +0100, Andrew Cooper wrote:

> > Did you instead mean this from libxl_types.idl:
> >     # Valid iff (shutdown||dying).
> >     #
> >     # Otherwise set to a value guaranteed not to clash with any valid
> >     # LIBXL_SHUTDOWN_REASON_* constant.
> >     ("shutdown_reason", libxl_shutdown_reason),
> > ?
> 
> That is the primary comment I was on about.

This wasn't tagged for 4.5 but it is a bug fix and the commit log &
associated commentary were pretty convincing, so Acked + Applied with
the additional hunk below folded in.

diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
index ca3f724..f7fc695 100644
--- a/tools/libxl/libxl_types.idl
+++ b/tools/libxl/libxl_types.idl
@@ -260,7 +260,7 @@ libxl_dominfo = Struct("dominfo",[
     ("shutdown",    bool),
     ("dying",       bool),
 
-    # Valid iff (shutdown||dying).
+    # Valid iff ->shutdown is true.
     #
     # Otherwise set to a value guaranteed not to clash with any valid
     # LIBXL_SHUTDOWN_REASON_* constant.