From: Ian Campbell <Ian.Campbell@citrix.com>
To: xen-devel <xen-devel@lists.xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Olaf Hering <olaf@aepfle.de>, Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>
Subject: Please *justify* your use of the for-4.5 tag when posting patches
Date: Tue, 4 Nov 2014 10:52:22 +0000 [thread overview]
Message-ID: <1415098342.11486.23.camel@citrix.com> (raw)
In-Reply-To: <1415098082.11486.19.camel@citrix.com>
On Tue, 2014-11-04 at 10:48 +0000, Ian Campbell wrote:
Reposting with a more eyecatching subject, since this was by far not the
only patch with this issue.
> In the future when you include a "for-4.5" tag on a patch please
> *always* state your reasoning (usually after the "---"). Don't make the
> maintainer / release manager / committer guess why you think it should
> be in 4.5. If you consider it "obviously a bug fix" then say so and then
> say something about the impact of the bug and the risk associated with
> the fix.
>
> I'm a bit grumpy about the number of patches which don't do this, such
> patches are mostly going to the back of my queue, alongside the 4.6
> patches, since without any rationale that is effectively what I consider
> them to be despite the use of the for-4.5 tag.
prev parent reply other threads:[~2014-11-04 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 14:09 [PATCH for-4.5] tools/pygrub: Fix TOCTOU race introduced by c/s 63dcc68 Andrew Cooper
2014-10-29 16:03 ` Olaf Hering
2014-10-29 18:09 ` Andrew Cooper
2014-10-29 19:43 ` Olaf Hering
2014-11-04 10:48 ` Ian Campbell
2014-11-04 10:52 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415098342.11486.23.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.