From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 4/5] drm/i915: Make scatter-gather helper available to the driver Date: Tue, 04 Nov 2014 13:56:05 +0200 Message-ID: <1415102165.7220.40.camel@intelbox> References: <1414687178-18562-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1414687178-18562-5-git-send-email-tvrtko.ursulin@linux.intel.com> <20141103160555.GA26941@phenom.ffwll.local> <20141103203020.GB13658@nuc-i3427.alporthouse.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FB136E20B for ; Tue, 4 Nov 2014 03:56:09 -0800 (PST) In-Reply-To: <20141103203020.GB13658@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE0LTExLTAzIGF0IDIwOjMwICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4g T24gTW9uLCBOb3YgMDMsIDIwMTQgYXQgMDU6MDU6NTVQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiA+IE9uIFRodSwgT2N0IDMwLCAyMDE0IGF0IDA0OjM5OjM3UE0gKzAwMDAsIFR2cnRr byBVcnN1bGluIHdyb3RlOgo+ID4gPiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3Vs aW5AaW50ZWwuY29tPgo+ID4gPiAKPiA+ID4gSXQgd2lsbCBiZSB1c2VkIGJ5IG90aGVyIGNhbGwg c2l0ZXMgc2hvcnRseS4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGlu IDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kbWEuYyAgICAgICAgIHwgMzggKysrKysrKysrKysrKysrKysrKysrKysr KysrKysKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3VzZXJwdHIuYyB8IDQz ICsrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHJ2LmggICAgICAgIHwgIDQgKysrCj4gPiA+ICAzIGZpbGVzIGNoYW5nZWQs IDQ0IGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2RtYS5jCj4gPiA+IGluZGV4IDViMTU3YmIuLjBiMzQ1NzEgMTAwNjQ0Cj4gPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMKPiA+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+ID4gPiBAQCAtMjA3MCwzICsyMDcwLDQxIEBAIGludCBp OTE1X2RyaXZlcl9kZXZpY2VfaXNfYWdwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiA+ICB7 Cj4gPiA+ICAJcmV0dXJuIDE7Cj4gPiA+ICB9Cj4gPiA+ICsKPiA+ID4gKyNpZiBJU19FTkFCTEVE KENPTkZJR19TV0lPVExCKQo+ID4gPiArI2RlZmluZSBzd2lvdGxiX2FjdGl2ZSgpIHN3aW90bGJf bnJfdGJsKCkKPiA+ID4gKyNlbHNlCj4gPiA+ICsjZGVmaW5lIHN3aW90bGJfYWN0aXZlKCkgMAo+ ID4gPiArI2VuZGlmCj4gPiA+ICsKPiA+ID4gK2ludCBpOTE1X3N0X3NldF9wYWdlcyhzdHJ1Y3Qg c2dfdGFibGUgKipzdCwgc3RydWN0IHBhZ2UgKipwdmVjLCBpbnQgbnVtX3BhZ2VzKQo+ID4gPiAr ewo+ID4gPiArCXN0cnVjdCBzY2F0dGVybGlzdCAqc2c7Cj4gPiA+ICsJaW50IHJldCwgbjsKPiA+ ID4gKwo+ID4gPiArCSpzdCA9IGttYWxsb2Moc2l6ZW9mKCoqc3QpLCBHRlBfS0VSTkVMKTsKPiA+ ID4gKwlpZiAoKnN0ID09IE5VTEwpCj4gPiA+ICsJCXJldHVybiAtRU5PTUVNOwo+ID4gPiArCj4g PiA+ICsJaWYgKHN3aW90bGJfYWN0aXZlKCkpIHsKPiA+ID4gKwkJcmV0ID0gc2dfYWxsb2NfdGFi bGUoKnN0LCBudW1fcGFnZXMsIEdGUF9LRVJORUwpOwo+ID4gPiArCQlpZiAocmV0KQo+ID4gPiAr CQkJZ290byBlcnI7Cj4gPiA+ICsKPiA+ID4gKwkJZm9yX2VhY2hfc2coKCpzdCktPnNnbCwgc2cs IG51bV9wYWdlcywgbikKPiA+ID4gKwkJCXNnX3NldF9wYWdlKHNnLCBwdmVjW25dLCBQQUdFX1NJ WkUsIDApOwo+ID4gPiArCX0gZWxzZSB7Cj4gPiA+ICsJCXJldCA9IHNnX2FsbG9jX3RhYmxlX2Zy b21fcGFnZXMoKnN0LCBwdmVjLCBudW1fcGFnZXMsCj4gPiA+ICsJCQkJCQkwLCBudW1fcGFnZXMg PDwgUEFHRV9TSElGVCwKPiA+ID4gKwkJCQkJCUdGUF9LRVJORUwpOwo+ID4gPiArCQlpZiAocmV0 KQo+ID4gPiArCQkJZ290byBlcnI7Cj4gPiA+ICsJfQo+ID4gCj4gPiBPaywgSSBkb24ndCByZWFs bHkgdW5kZXJzdGFuZCB3aHkgd2UgZG9uJ3QganVzdCBhbHdheXMgdXNlCj4gPiBzZ19hbGxvY190 YWJsZV9mcm9tX3BhZ2VzIHVuZGNvbmRpdGlvbmFsbHkgLSBpZiBzd2lvdGxiIF9ldmVyXyBnZXRz IGluCj4gPiBiZXR3ZWVuIHVzIGFuZCB0aGUgaHcsIGV2ZXJ5dGhpbmcgd2lsbCBwcmV0dHkgbXVj aCBmYWxsIGFwYXJ0Lgo+ID4gCj4gPiBnaXQgYmxhbWUgZG9lc24ndCBzaGVkIGxpZ2h0IG9uIHRo aXMgcGFydGljdWxhciBpc3N1ZS4gQ2hyaXM/Cj4gCj4gVGhpcyBpcyBJbXJlJ3Mgd29yay4uLgoK QWZhaWN0LCB0aGUgZGlzdGluY3Rpb24gd2FzIG1hZGUgYmVjYXVzZSBvZiBzd2lvdGxiJ3MgbGlt aXRhdGlvbiwgd2hpY2gKcHJldmVudGVkIHVzIGZyb20gdXNpbmcgY29tcGFjdCBzZyB0YWJsZXMg cHJvZHVjZWQgYnkKc2dfYWxsb2NfdGFibGVfZnJvbV9wYWdlcygpLiBUaGUgY29tbWl0IGJlbG93 IGV4cGxhaW5zIGl0IG1vcmU6Cgpjb21taXQgNDI2NzI5ZGNjNzEzYjNkMWFlODAyZTMxNDAzMGU1 NTU2YTYyZGE1MwpBdXRob3I6IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3Jh Y2xlLmNvbT4KRGF0ZTogICBNb24gSnVuIDI0IDExOjQ3OjQ4IDIwMTMgLTA0MDAKCiAgICBkcm0v aTkxNTogbWFrZSBjb21wYWN0IGRtYSBzY2F0dGVyIGxpc3RzIGNyZWF0aW9uIHdvcmsgd2l0aCBT V0lPVExCCmJhY2tlbmQuCiAgICAKICAgIEdpdCBjb21taXQgOTA3OTdlNmQxZWMwZGZkZTZiYTYy YTQ4YjllZTM4MDM4ODdkNmVkNAogICAgKCJkcm0vaTkxNTogY3JlYXRlIGNvbXBhY3QgZG1hIHNj YXR0ZXIgbGlzdHMgZm9yIGdlbSBvYmplY3RzIikgbWFrZXMKICAgIGNlcnRhaW4gYXNzdW1wdGlv bnMgYWJvdXQgdGhlIHVuZGVyIGxheWluZyBETUEgQVBJIHRoYXQgYXJlIG5vdAphbHdheXMKICAg IGNvcnJlY3QuCiAgICAKICAgIE9uIGEgVGhpbmtQYWQgWDIzMCB3aXRoIGFuIEludGVsIEhEIDQw MDAgd2l0aCBYZW4gZHVyaW5nIHRoZSBib290dXAKICAgIEkgc2VlOgogICAgCiAgICBbZHJtOmlu dGVsX3BpcGVfc2V0X2Jhc2VdICpFUlJPUiogcGluICYgZmVuY2UgZmFpbGVkCiAgICBbZHJtOmlu dGVsX2NydGNfc2V0X2NvbmZpZ10gKkVSUk9SKiBmYWlsZWQgdG8gc2V0IG1vZGUgb24gW0NSVEM6 M10sCmVyciA9IC0yOAogICAgCiAgICBCaXQgb2YgZGVidWdnaW5nIHRyYWNlZCBpdCBkb3duIHRv IGRtYV9tYXBfc2cgZmFpbGluZyAoaW4KICAgIGk5MTVfZ2VtX2d0dF9wcmVwYXJlX29iamVjdCkg YXMgc29tZSBvZiB0aGUgU0cgZW50cmllcyB3ZXJlIGh1Z2UKKDNNQikuCiAgICAKICAgIFRoYXQg dW5mb3J0dW5hdGVseSBhcmUgc2l6ZXMgdGhhdCB0aGUgU1dJT1RMQiBpcyBpbmNhcGFibGUgb2YK aGFuZGxpbmcgLQogICAgdGhlIG1heGltdW0gaXQgY2FuIGhhbmRsZSBpcyBhIGFuIGVudHJ5IG9m IDUxMktCIG9mIHZpcnR1YWwKY29udGlndW91cwogICAgbWVtb3J5IGZvciBpdHMgYm91bmNlIGJ1 ZmZlci4gKFNlZSBJT19UTEJfU0VHU0laRSkuCiAgICAKICAgIFByZXZpb3VzIHRvIHRoZSBhYm92 ZSBtZW50aW9uIGdpdCBjb21taXQgdGhlIFNHIGVudHJpZXMgd2VyZSBvZiA0S0IsCmFuZAogICAg dGhlIGNvZGUgaW50cm9kdWNlZCBieSBhYm92ZSBnaXQgY29tbWl0IHNxdWFzaGVkIHRoZSBDUFUg Y29udGlndW91cwpQRk5zCiAgICBpbiBvbmUgYmlnIHZpcnR1YWwgYWRkcmVzcyBwcm92aWRlZCB0 byBETUEgQVBJLgogICAgCiAgICBUaGlzIHBhdGNoIGlzIGEgc2ltcGxlIHNlbWktcmV2ZXJ0IC0g d2VyZSB3ZSBlbXVsYXRlIHRoZSBvbGQKYmVoYXZpb3IKICAgIGlmIHdlIGRldGVjdCB0aGF0IFNX SU9UTEIgaXMgb25saW5lLiBJZiBpdCBpcyBub3Qgb25saW5lIHRoZW4gd2UKY29udGludWUKICAg IG9uIHdpdGggdGhlIG5ldyBjb21wYWN0IHNjYXR0ZXIgZ2F0aGVyIG1lY2hhbmlzbS4KICAgIAog ICAgQW4gYWx0ZXJuYXRpdmUgc29sdXRpb24gd291bGQgYmUgZm9yIHRoZSB0aGUgJy5nZXRfcGFn ZXMnIGFuZCB0aGUKICAgIGk5MTVfZ2VtX2d0dF9wcmVwYXJlX29iamVjdCB0byByZXRyeSB3aXRo IHNtYWxsZXIgbWF4IGdhcCBvZiB0aGUKICAgIGFtb3VudCBvZiBQRk5zIHRoYXQgY2FuIGJlIGNv bWJpbmVkIHRvZ2V0aGVyIC0gYnV0IHdpdGggdGhpcyBpc3N1ZQogICAgZGlzY292ZXJlZCBkdXJp bmcgcmM3IHRoYXQgbWlnaHQgYmUgdG9vIHJpc2t5LgogICAgCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK