From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
backports@vger.kernel.org, linux-kernel@vger.kernel.org,
yann.morin.1998@free.fr, mmarek@suse.cz, sassmann@kpanic.de
Subject: Re: [PATCH v1 10/11] backports: prefix c-file / h-file auto backport with BPAUTO
Date: Wed, 05 Nov 2014 09:12:03 +0100 [thread overview]
Message-ID: <1415175123.2589.10.camel@sipsolutions.net> (raw)
In-Reply-To: <20141105080252.GK12953@wotan.suse.de>
On Wed, 2014-11-05 at 09:02 +0100, Luis R. Rodriguez wrote:
> > But the *code* changes
> > you're making here that check whether bp_prefix is being duplicated
> > aren't necessary for that, and are in fact confusing and dangerous.
>
> Understood, thanks for the review, hopefully this is addressed with the
> latest series.
Actually, maybe you wanted these changes because you didn't want to end
up with CONFIG_BACKPORT_BPAUTO_ for integration? I think that's a small
price to pay though for code complexity trade-off, IMHO you should
accept CONFIG_BACKPORT_BPAUTO_ and remove the code changes.
johannes
next prev parent reply other threads:[~2014-11-05 8:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 8:42 [PATCH v1 00/11] backports: add kernel integration support Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 01/11] backports: move legacy and SmPL patch application into helper Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 02/11] backports: extend module_init() module_exit() for built-in Luis R. Rodriguez
2014-11-04 10:02 ` Johannes Berg
2014-11-04 8:42 ` [PATCH v1 03/11] backports: allow for different backport prefix Luis R. Rodriguez
2014-11-04 10:05 ` Johannes Berg
2014-11-04 21:45 ` Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 04/11] backports: replace BACKPORT_PWD with BACKPORT_DIR Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 05/11] backports: use BACKPORT_DIR prefix on kconfig sources Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 06/11] backports: update dependencies map file Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 07/11] backports: split Kconfig into Kconfig.package and Kconfig.sources Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 08/11] backports: move version file generation to run earlier Luis R. Rodriguez
2014-11-04 8:43 ` [PATCH v1 09/11] backports: use Kconfig for backport version information Luis R. Rodriguez
2014-11-04 10:13 ` Johannes Berg
2014-11-04 21:51 ` Luis R. Rodriguez
2014-11-04 23:33 ` Luis R. Rodriguez
2014-11-04 8:43 ` [PATCH v1 10/11] backports: prefix c-file / h-file auto backport with BPAUTO Luis R. Rodriguez
2014-11-04 10:14 ` Johannes Berg
2014-11-04 21:50 ` Luis R. Rodriguez
2014-11-04 21:50 ` Johannes Berg
2014-11-05 0:21 ` Luis R. Rodriguez
2014-11-05 7:29 ` Johannes Berg
2014-11-05 8:02 ` Luis R. Rodriguez
2014-11-05 8:12 ` Johannes Berg [this message]
2014-11-05 8:20 ` Luis R. Rodriguez
2014-11-04 8:43 ` [PATCH v1 11/11] backports: add full kernel integration support Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415175123.2589.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mmarek@suse.cz \
--cc=sassmann@kpanic.de \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.