All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Koen Kooi <koen.kooi@linaro.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] lsb 4.1: Deal with "make clean" breakage
Date: Wed, 05 Nov 2014 10:48:46 +0000	[thread overview]
Message-ID: <1415184526.23396.43.camel@ted> (raw)
In-Reply-To: <1415108447-16821-1-git-send-email-koen.kooi@linaro.org>

On Tue, 2014-11-04 at 14:40 +0100, Koen Kooi wrote:
> LSB can't cope with a "make clean" so disable that
> newly enabled functionality.
> 
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> ---
>  meta/recipes-extended/lsb/lsb_4.1.bb | 6 ++++++
>  1 file changed, 6 insertions(+)

In the interests of being clear and transparent, there are issues with
the clean change and I think we need a better mechanism for controlling
this. I've a patch in progress which introduces a CLEANBROKEN variable
which can be set in recipes where "make clean" is broken.

I have a list of several other recipes with the issue and am working on
pulling together a list/patch.

Cheers,

Richard


> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
> index d265731..34a70d0 100644
> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -21,6 +21,12 @@ SRC_URI[md5sum] = "30537ef5a01e0ca94b7b8eb6a36bb1e4"
>  SRC_URI[sha256sum] = "99321288f8d62e7a1d485b7c6bdccf06766fb8ca603c6195806e4457fdf17172"
>  S = "${WORKDIR}/lsb-release-1.4"
>  
> +# 'make clean' isn't supported
> +
> +do_configure() {
> +	:
> +}
> +
>  do_install(){
>  	oe_runmake install prefix=${D}  mandir=${D}/${datadir}/man/ DESTDIR=${D}
>  
> -- 
> 1.9.3
> 




      parent reply	other threads:[~2014-11-05 10:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 13:40 [PATCH 1/3] lsb 4.1: Deal with "make clean" breakage Koen Kooi
2014-11-04 13:40 ` [PATCH 2/3] lsb 4.1: fix /usr/lib/ hardcodes Koen Kooi
2014-11-04 14:52   ` Mark Hatle
2014-11-04 13:40 ` [PATCH 3/3] lsb 4.1: fix indentation Koen Kooi
2014-11-05 10:48 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415184526.23396.43.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=koen.kooi@linaro.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.