All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: New WARNING from mac80211
Date: Thu, 06 Nov 2014 16:03:37 +0100	[thread overview]
Message-ID: <1415286217.17015.12.camel@sipsolutions.net> (raw)
In-Reply-To: <545B8CD1.8020208@lwfinger.net> (sfid-20141106_155933_146634_B5D1D491)

On Thu, 2014-11-06 at 08:59 -0600, Larry Finger wrote:

> The warning comes from the following fragment in net/mac80211/agg-tx.c:
> 
>          if (WARN_ON(!tid_tx)) {
>                  ht_dbg(sdata, "addBA was not requested!\n");
>                  goto unlock;
>          }
> 
> Is there something that should be fixed in rtl8192se?

That sounds like the driver is calling ieee80211_start_tx_ba_cb() [*]
when it was never requested to start aggregation?

[*] given the stack dump, it's actually calling
ieee80211_start_tx_ba_cb_irqsafe() which goes off to a workqueue and
then calls ieee80211_start_tx_ba_cb() from there

johannes


  reply	other threads:[~2014-11-06 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 14:59 New WARNING from mac80211 Larry Finger
2014-11-06 15:03 ` Johannes Berg [this message]
2014-11-06 15:40   ` Sujith Manoharan
2014-11-06 15:50     ` Sujith Manoharan
2014-12-12 12:59       ` Johannes Berg
2014-12-15  1:43         ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415286217.17015.12.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.