Re: [PATCH] mac80211: add back support for radiotap vendor namespace data

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2014-11-07 at 14:37 +0200, Luca Coelho wrote:

> > +#if 0
> > +	struct ieee80211_vendor_radiotap *rtap;
> > +
> > +	rtap = (void *)skb_push(skb, sizeof(*rtap) + 8 + 4);
> > +	/*
> > +	 * Don't enable this code by default as the OUI 00:00:00
> > +	 * is registered to Xerox so we shouldn't use it here, it
> > +	 * might find its way into pcap files.
> > +	 * Note that this code requires the headroom in the SKB
> > +	 * that was allocated earlier.
> > +	 */

> Is this #if 0'ed section here on purpose? If yes, maybe explain it in
> the commit message?

You're the second person to ask this, but come on ... really? :)

johannes