From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 4/4] libxl: CODING_STYLE: Discuss existing style problems Date: Mon, 10 Nov 2014 12:30:19 +0000 Message-ID: <1415622619.25176.6.camel@citrix.com> References: <1415198630-29937-1-git-send-email-ian.jackson@eu.citrix.com> <1415198630-29937-5-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1415198630-29937-5-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Wed, 2014-11-05 at 14:43 +0000, Ian Jackson wrote: > +If it is not feasible to conform fully to the style while patching old > +code, without doing substantial style reengineering first, we may > +accept patches which contain nonconformant elements, provided that > +they don't make the coding style problem worse overall. I'd perhaps be a little more explicit and say that the exceptional code should conform to the (probably implicit) prevailing style in the area so far as that is possible. Ian.