From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: xl list -l doesn't work for incoming domain
Date: Mon, 10 Nov 2014 14:05:49 +0000
Message-ID: <1415628349.25176.19.camel@citrix.com>
References: <545BC8A2.20604@oracle.com>
	<20141107104752.GB28188@zion.uk.xensource.com>
	<545CF499.8080606@oracle.com>
	<20141110123525.GD28360@zion.uk.xensource.com>
	<1415623133.25176.10.camel@citrix.com>
	<20141110135419.GB32371@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Xnpbn-00061M-Uk
	for xen-devel@lists.xenproject.org; Mon, 10 Nov 2014 14:06:20 +0000
In-Reply-To: <20141110135419.GB32371@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Zhigang Wang <zhigang.x.wang@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-11-10 at 13:54 +0000, Wei Liu wrote:
> > Can we write a stub json file at the beginning of migrate receive, a bit
> > like we do on create?
> > 
> 
> No, we don't generate stub for normal domain at the moment.

Oh, I thought we did.

SO what happens if someone runs "xl list" while a domain create is in
progress? 

> Whether we should do it or not, it depends on whether we want libxl user
> to see incomplete (and certainly incorrect) domain configuration. I
> think not, because libxl user doesn't know how to distinguish stub
> (invalid) configuration from a valid one.
> 
> > Otherwise code like xl list is going to have start special casing
> > domains which have no json, which we've tried hard to avoid I think.
> > 
> 
> From xl's (and other tools on the same level) point of view, that means
> invocation of library function fails, which it should always be ready to
> cope with.

So your opinion is that the bug is the "libxl: error:
libxl.c:6535:libxl_retrieve_domain_configuration: fail to get domain
configuration for domain 7" message which should be removed?

I'd be happy enough with domain 7 being listed with an empty cfg in that
case.

Ian.