From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: hariprasad@chelsio.com, netdev@vger.kernel.org,
leedom@chelsio.com, anish@chelsio.com, praveenm@chelsio.com,
nirranjan@chelsio.com, kumaras@chelsio.com, j.vosburgh@gmail.com,
vfalico@gmail.com, andy@greyhouse.net
Subject: Re: [PATCH net-next] cxgb4: Remove unnecessary struct in6_addr * casts
Date: Mon, 10 Nov 2014 10:48:18 -0800 [thread overview]
Message-ID: <1415645298.8868.10.camel@perches.com> (raw)
In-Reply-To: <20141110.132837.1817456437352515704.davem@davemloft.net>
On Mon, 2014-11-10 at 13:28 -0500, David Miller wrote:
> From: Joe Perches <joe@perches.com> Date: Thu, 06 Nov 2014 20:46:14 -0800
[]
> >> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> > []
> >> #include <../drivers/net/bonding/bonding.h>
> >
> > This include path seems unfortunate so I looked
> > at the code a bit. I don't see an easy way to change it.
> >
> > Maybe some of bonding.h should be moved into a new file
> > like 'include/net/bonding.h' or something.
>
> I just committed the following into net-next, thanks for pointing
> this out.
Thanks.
btw: using "git format-patch -M" makes reading and
verifying the patch a lot easier.
Unfortunately, there's no current way to make this
a global default for everyone, but I have this in
my ~/.gitconfig:
[diff]
renames = true
next prev parent reply other threads:[~2014-11-10 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 4:05 [PATCHv3 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros Hariprasad Shenai
2014-11-07 4:05 ` [PATCHv3 net-next 1/3] cxgb4: Add cxgb4_debugfs.c, move all debugfs code to new file Hariprasad Shenai
2014-11-07 4:46 ` [PATCH net-next] cxgb4: Remove unnecessary struct in6_addr * casts Joe Perches
2014-11-10 18:28 ` David Miller
2014-11-10 18:48 ` Joe Perches [this message]
2014-11-10 19:09 ` David Miller
2014-11-10 19:23 ` Joe Perches
2014-11-07 4:05 ` [PATCHv3 net-next 2/3] cxgb4: Cleanup macros so they follow the same style and look consistent Hariprasad Shenai
2014-11-07 4:05 ` [PATCHv3 net-next 3/3] cxgb4: Cleanup macros so they follow the same style and look consistent, part 2 Hariprasad Shenai
2014-11-10 17:57 ` [PATCHv3 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415645298.8868.10.camel@perches.com \
--to=joe@perches.com \
--cc=andy@greyhouse.net \
--cc=anish@chelsio.com \
--cc=davem@davemloft.net \
--cc=hariprasad@chelsio.com \
--cc=j.vosburgh@gmail.com \
--cc=kumaras@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=praveenm@chelsio.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.