From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: xl mem-max error
Date: Wed, 12 Nov 2014 12:03:17 +0000
Message-ID: <1415793797.29592.12.camel@citrix.com>
References: <545BF386.1050106@oracle.com>
	<20141107110512.GA12109@zion.uk.xensource.com>
	<545CD572.9040801@oracle.com>
	<20141110123747.GE28360@zion.uk.xensource.com>
	<1415623447.25176.12.camel@citrix.com> <5460D9C5.4020905@oracle.com>
	<1415633435.25176.27.camel@citrix.com> <5460DBEF.5000504@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XoWdx-0000mX-5S
	for xen-devel@lists.xenproject.org; Wed, 12 Nov 2014 12:03:25 +0000
In-Reply-To: <5460DBEF.5000504@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Zhigang Wang <zhigang.x.wang@oracle.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-11-10 at 10:38 -0500, Zhigang Wang wrote:
> OK. Let me try my best:
> 
> >>> I'm confused by the description of what's going on, in particular the
> >>> mixing of mem-max commands and target xenstore nodes (since the former
> >>> doesn't really affect the latter).
> >>>
> >>> How was the domain started (memory= and maxmem=).
> 
> xl create with 'memory = 700', no maxmem been set. I think it means maxmem = memory for this case.
> 
> >>> What were static-max and target at the point?
> 
>      /local/domain/3/memory/static-max = "716800"
>      /local/domain/3/memory/target = "716801"
> 
> >>> What did they change to when xl mem-max was issued? 
> 
> When I issue 'xl mem-max <domid> 700', static-max and target in xenstore will not change, but it will cause the command to fail.
> 
> Because: "libxl: error: libxl.c:4549:libxl_domain_setmaxmem: memory_static_max must be greater than or or equal to memory_dynamic_max"
> 
> >>> What did you expect them to change to instead?
> 
> I expect I can set the maxmem to the same value I initially set (700).

OK, thanks, got it. I think the use of xl mem-max is a bit of a
red-herring, the issue here is that static-max < target at start of day.

I suspect there is either a rounding error somewhere or because of
LIBXL_MAXMEM_CONSTANT being inconsistently applied to the two values
somewhere along the line.

We had been planning[0] to remove this early in the 4.5 cycle, but as
ever it never floated to the top of anyone's list. For 4.5 we should
probably look at applying this fudge more consistently.

Ian.

[0] http://bugs.xenproject.org/xen/bug/23