From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] mkdeb previously set the package architecture to be 'amd64' for anything other than XEN_TARGET_ARCH=x86_32. This patch attempts to correctly map the architecture from GNU names to debian names for x86 and ARM architectures, or otherwise, defaults it to the value in XEN_TARGET_ARCH. Date: Wed, 12 Nov 2014 15:30:09 +0000 Message-ID: <1415806209.1155.19.camel@citrix.com> References: <1415806043-28199-1-git-send-email-clark.laughlin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XoZs9-0007fZ-Dn for xen-devel@lists.xenproject.org; Wed, 12 Nov 2014 15:30:17 +0000 In-Reply-To: <1415806043-28199-1-git-send-email-clark.laughlin@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Clark Laughlin Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-11-12 at 09:27 -0600, Clark Laughlin wrote: > Signed-off-by: Clark Laughlin Acked-by: Ian Campbell The mapping is a bit more zealous that strictly needed: > +# map the architecture, if necessary > +arch=$XEN_TARGET_ARCH > +case "$XEN_TARGET_ARCH" in > + x86_32) arch=i386 ;; > + i686) arch=i386 ;; > + x86_64) arch=amd64 ;; > + arm32) arch=armhf ;; > + aarch64) arch=arm64 ;; > +esac I don't think $XEN_TARGET_ARCH can ever be i686 or aarch64, that would break all over the place I think. Not that there is any harm in handling those cases. Ian.