All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Wang, Yalin" <Yalin.Wang@sonymobile.com>
Cc: "'perex@perex.cz'" <perex@perex.cz>,
	"'tiwai@suse.de'" <tiwai@suse.de>,
	"'alsa-devel@alsa-project.org'" <alsa-devel@alsa-project.org>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 6fire: Convert byte_rev_table uses to bitrev8
Date: Thu, 13 Nov 2014 21:45:34 -0800	[thread overview]
Message-ID: <1415943934.5912.6.camel@perches.com> (raw)
In-Reply-To: <35FD53F367049845BC99AC72306C23D103E010D1829C@CNBJMBX05.corpusers.net>

On Fri, 2014-11-14 at 13:13 +0800, Wang, Yalin wrote:
> Use the inline function instead of directly indexing the array.
> 
> This allows some architectures with hardware instructions for bit
> reversals to eliminate the array.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
> ---
[]
> diff --git a/sound/usb/6fire/firmware.c b/sound/usb/6fire/firmware.c
[]
> @@ -316,7 +316,7 @@ static int usb6fire_fw_fpga_upload(
>  
>  	while (c != end) {
>  		for (i = 0; c != end && i < FPGA_BUFSIZE; i++, c++)
> -			buffer[i] = byte_rev_table[(u8) *c];
> +			buffer[i] = bitrev8((u8) *c);

This is not what I submitted.
What I posted did not have a space after (u8)

https://lkml.org/lkml/2014/10/28/1056

If you are going to resubmit or add your own sign-off,
please try to maintain the proper patch that is
submitted and please also use a "From:" line before
the patch itself.

Thanks, Joe

  reply	other threads:[~2014-11-14  5:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14  5:13 [PATCH] 6fire: Convert byte_rev_table uses to bitrev8 Wang, Yalin
2014-11-14  5:45 ` Joe Perches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-10-24  5:10 [PATCH RFC] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit Wang, Yalin
2014-10-27  6:37 ` [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction Wang, Yalin
2014-10-27  6:46   ` Joe Perches
2014-10-28 21:22     ` [PATCH] 6fire: Convert byte_rev_table uses to bitrev8 Joe Perches
2014-10-28 21:22       ` Joe Perches
2014-10-28 21:22       ` Joe Perches
2014-10-29  2:42       ` Wang, Yalin
2014-10-29  2:42         ` Wang, Yalin
2014-10-29  2:42         ` Wang, Yalin
2014-10-29  3:06         ` Joe Perches
2014-10-29  3:06           ` Joe Perches
2014-10-29  3:06           ` Joe Perches
2014-10-29  3:10           ` Wang, Yalin
2014-10-29  3:10             ` Wang, Yalin
2014-10-29  3:10             ` Wang, Yalin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415943934.5912.6.camel@perches.com \
    --to=joe@perches.com \
    --cc=Yalin.Wang@sonymobile.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.