From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 2/2] drm/exynos/dsi: Add runtime PM so LCD power domain could be turned off Date: Fri, 14 Nov 2014 08:32:58 +0100 Message-ID: <1415950378.25732.0.camel@AMDC1943> References: <1415368439-23642-1-git-send-email-k.kozlowski@samsung.com> <1415368439-23642-3-git-send-email-k.kozlowski@samsung.com> <54656E9A.8040702@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <54656E9A.8040702@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae Cc: Kukjin Kim , Bartlomiej Zolnierkiewicz , Kevin Hilman , Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Kyungmin Park , linux-samsung-soc@vger.kernel.org, Grygorii Strashko , linux-arm-kernel@lists.infradead.org, Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gcGnEhSwgMjAxNC0xMS0xNCBhdCAxMTo1MyArMDkwMCwgSW5raSBEYWUgd3JvdGU6Cj4gT24g MjAxNOuFhCAxMeyblCAwN+ydvCAyMjo1MywgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPiA+ IEFkZCBydW50aW1lIFBvd2VyIE1hbmFnZW1lbnQgdG8gdGhlIEV4eW5vcyBEU0kgZHJpdmVyIHNv IHRoZSBMQ0QgcG93ZXIKPiA+IGRvbWFpbiBjb3VsZCBiZSB0dXJuZWQgb2ZmLgo+ID4gCj4gPiBU aGlzIHNsaWdodGx5IHJlZHVjZXMgdGhlIGVuZXJneSBjb25zdW1wdGlvbiB3aGVuIHNjcmVlbiBp cyBjb21wbGV0ZWx5Cj4gPiB0dXJuZWQgb2ZmLiBPbiBUcmF0czIgYm9hcmQgd2hlbiB0aGUgc3lz dGVtIHdhcyBpZGxlIHRoZSBlbmVyZ3kKPiA+IGNvbnN1bXB0aW9uIGRyb3BwZWQgYnkgMSUgKGZy b20gOTIuMiBtQSB0byA5MS4xIG1BKS4KPiA+IAo+ID4gQmVmb3JlIHRoZSBwYXRjaDoKPiA+ICQg Y2F0IGNhdCAvc3lzL2tlcm5lbC9kZWJ1Zy9wbV9nZW5wZC9wbV9nZW5wZF9zdW1tYXJ5Cj4gPiBs Y2QwLXBvd2VyLWRvbWFpbiAgICAgICAgICAgICAgIG9uCj4gPiAgICAgL2RldmljZXMvMTFjMDAw MDAuZmltZCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN1c3BlbmRlZAo+ID4gICAgIC9k ZXZpY2VzLzExYzgwMDAwLmRzaSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnN1cHBv cnRlZAo+ID4gCj4gPiBBZnRlciBhcHBseWluZyB0aGUgcGF0Y2g6Cj4gPiBsY2QwLXBvd2VyLWRv bWFpbiAgICAgICAgICAgICAgIG9mZgo+ID4gICAgIC9kZXZpY2VzLzExYzAwMDAwLmZpbWQgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzdXNwZW5kZWQKPiA+ICAgICAvZGV2aWNlcy8xMWM4 MDAwMC5kc2kgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3VzcGVuZGVkCj4gCj4gUmVh c29uYWJsZSBidXQgdGhpcyBwYXRjaCBpbmN1cnMgcGFnZSBmbGlwIHRlc3QgdGltZW91dCBsaWtl IGJlbG93LAo+ICMgbW9kZXRlc3QgLXYgLXMgMTVAMTI6NzIweDEyODAKPiB0cnlpbmcgdG8gb3Bl biBkZXZpY2UgJ2k5MTUnLi4uZmFpbGVkLgo+IHRyeWluZyB0byBvcGVuIGRldmljZSAncmFkZW9u Jy4uLmZhaWxlZC4KPiB0cnlpbmcgdG8gb3BlbiBkZXZpY2UgJ25vdXZlYXUnLi4uZmFpbGVkLgo+ IHRyeWluZyB0byBvcGVuIGRldmljZSAndm13Z2Z4Jy4uLmZhaWxlZC4KPiB0cnlpbmcgdG8gb3Bl biBkZXZpY2UgJ29tYXBkcm0nLi4uZmFpbGVkLgo+IHRyeWluZyB0byBvcGVuIGRldmljZSAnZXh5 bm9zJy4uLnN1Y2Nlc3MuCj4gc2V0dGluZyBtb2RlIDcyMHgxMjgwLTBIekBYUjI0IG9uIGNvbm5l Y3RvcnMgMTUsIGNydGMgMTIKPiBzZWxlY3QgdGltZWQgb3V0IG9yIGVycm9yIChyZXQgMCkKPiAK PiBJJ20gbm90IHN1cmUgd2h5IHRoaXMgaXNzdWUgaXMgaW5jdXJyZWQgd2l0aCB0aGlzIHBhdGNo IGV2ZW4gdGhyb3VnaAo+IHRoaXMgcGF0Y2ggaXMgcmVhc29uYWJsZSBhbmQgY29ycmVjdC4gU28g d2UgbmVlZCBtb3JlIGNoZWNraW5nLgo+IAo+IFAuUy4gSSB0ZXN0ZWQgaXQgb24gZXh5bm9zLWRy bS1uZXh0IGFuZCBtMCBib2FyZC4KClRoYW5rcyBmb3IgcG9pbnRpbmcgdGhpcyBpc3N1ZS4gSSds bCBpbnZlc3RpZ2F0ZSBpdC4KCkJlc3QgcmVnYXJkcywKS3J6eXN6dG9mCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 14 Nov 2014 08:32:58 +0100 Subject: [PATCH v2 2/2] drm/exynos/dsi: Add runtime PM so LCD power domain could be turned off In-Reply-To: <54656E9A.8040702@samsung.com> References: <1415368439-23642-1-git-send-email-k.kozlowski@samsung.com> <1415368439-23642-3-git-send-email-k.kozlowski@samsung.com> <54656E9A.8040702@samsung.com> Message-ID: <1415950378.25732.0.camel@AMDC1943> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On pi?, 2014-11-14 at 11:53 +0900, Inki Dae wrote: > On 2014? 11? 07? 22:53, Krzysztof Kozlowski wrote: > > Add runtime Power Management to the Exynos DSI driver so the LCD power > > domain could be turned off. > > > > This slightly reduces the energy consumption when screen is completely > > turned off. On Trats2 board when the system was idle the energy > > consumption dropped by 1% (from 92.2 mA to 91.1 mA). > > > > Before the patch: > > $ cat cat /sys/kernel/debug/pm_genpd/pm_genpd_summary > > lcd0-power-domain on > > /devices/11c00000.fimd suspended > > /devices/11c80000.dsi unsupported > > > > After applying the patch: > > lcd0-power-domain off > > /devices/11c00000.fimd suspended > > /devices/11c80000.dsi suspended > > Reasonable but this patch incurs page flip test timeout like below, > # modetest -v -s 15 at 12:720x1280 > trying to open device 'i915'...failed. > trying to open device 'radeon'...failed. > trying to open device 'nouveau'...failed. > trying to open device 'vmwgfx'...failed. > trying to open device 'omapdrm'...failed. > trying to open device 'exynos'...success. > setting mode 720x1280-0Hz at XR24 on connectors 15, crtc 12 > select timed out or error (ret 0) > > I'm not sure why this issue is incurred with this patch even through > this patch is reasonable and correct. So we need more checking. > > P.S. I tested it on exynos-drm-next and m0 board. Thanks for pointing this issue. I'll investigate it. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754656AbaKNHdF (ORCPT ); Fri, 14 Nov 2014 02:33:05 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:16792 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754570AbaKNHdD (ORCPT ); Fri, 14 Nov 2014 02:33:03 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f4-b7f6c6d00000120b-02-5465b02cd347 Content-transfer-encoding: 8BIT Message-id: <1415950378.25732.0.camel@AMDC1943> Subject: Re: [PATCH v2 2/2] drm/exynos/dsi: Add runtime PM so LCD power domain could be turned off From: Krzysztof Kozlowski To: Inki Dae Cc: Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Kukjin Kim , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Andrzej Hajda , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Grygorii Strashko , Kevin Hilman Date: Fri, 14 Nov 2014 08:32:58 +0100 In-reply-to: <54656E9A.8040702@samsung.com> References: <1415368439-23642-1-git-send-email-k.kozlowski@samsung.com> <1415368439-23642-3-git-send-email-k.kozlowski@samsung.com> <54656E9A.8040702@samsung.com> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsVy+t/xq7o6G1JDDD61sFrcWneO1aL33Ekm i40z1rNaXPn6ns1i5RQWi0n3J7BYvLh3kcWid8FVNounmx8zWZxtesNusenxNVaLy7vmsFnM OL+PyWLtkbvsFjMmv2Rz4PfYtKqTzWP7twesHve7jzN5bF5S79G3ZRWjx/Eb25k8Pm+SC2CP 4rJJSc3JLEst0rdL4MrY+GwWY8Fk3op/XdENjMc5uxg5OSQETCRaZrxmh7DFJC7cW8/WxcjF ISSwlFHi58TjzCAJXgFBiR+T77F0MXJwMAvISxy5lA0SZhZQl5g0bxEzRP1nRonjnQtYIer1 JTYfuMUEYgsLpEgcfPOQEcRmEzCW2Lx8CRuILSKgLLFqXzs7SDOzwFYWid2fv7GDLGARUJV4 N7cIpIZTQFvi8bPVUActY5To6bvGClIjAdTc2O82gVFgFpLzZiGcNwvJeQsYmVcxiqaWJhcU J6XnGuoVJ+YWl+al6yXn525ihETQlx2Mi49ZHWIU4GBU4uE1KEgNEWJNLCuuzD3EKMHBrCTC u2A2UIg3JbGyKrUoP76oNCe1+BAjEwenVAOjnWA9C9vXRScv3rNIOn92/gbtnRuD/p29/sDq /PNzyz7fNHdalmjwqG3bRB3F/z5c4kbWr81+i06aJ5J57eV+XRXjPeId7EuCG499KdnCv/xW yMUUgZd/9wgvjmhcnzdZZk7CgvbzJe/+XNadm1t7ZNHbZsvPovZFFvlslWIGIVF7t7s33fuj o8RSnJFoqMVcVJwIAIsOK85+AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pią, 2014-11-14 at 11:53 +0900, Inki Dae wrote: > On 2014년 11월 07일 22:53, Krzysztof Kozlowski wrote: > > Add runtime Power Management to the Exynos DSI driver so the LCD power > > domain could be turned off. > > > > This slightly reduces the energy consumption when screen is completely > > turned off. On Trats2 board when the system was idle the energy > > consumption dropped by 1% (from 92.2 mA to 91.1 mA). > > > > Before the patch: > > $ cat cat /sys/kernel/debug/pm_genpd/pm_genpd_summary > > lcd0-power-domain on > > /devices/11c00000.fimd suspended > > /devices/11c80000.dsi unsupported > > > > After applying the patch: > > lcd0-power-domain off > > /devices/11c00000.fimd suspended > > /devices/11c80000.dsi suspended > > Reasonable but this patch incurs page flip test timeout like below, > # modetest -v -s 15@12:720x1280 > trying to open device 'i915'...failed. > trying to open device 'radeon'...failed. > trying to open device 'nouveau'...failed. > trying to open device 'vmwgfx'...failed. > trying to open device 'omapdrm'...failed. > trying to open device 'exynos'...success. > setting mode 720x1280-0Hz@XR24 on connectors 15, crtc 12 > select timed out or error (ret 0) > > I'm not sure why this issue is incurred with this patch even through > this patch is reasonable and correct. So we need more checking. > > P.S. I tested it on exynos-drm-next and m0 board. Thanks for pointing this issue. I'll investigate it. Best regards, Krzysztof