From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for-4.5 2/2] xl: print out partial
 configuration in long mode of list command
Date: Fri, 14 Nov 2014 10:22:35 +0000
Message-ID: <1415960555.21321.28.camel@citrix.com>
References: <1415811865-19981-1-git-send-email-wei.liu2@citrix.com>
	<1415811865-19981-3-git-send-email-wei.liu2@citrix.com>
	<1415959140.21321.21.camel@citrix.com>
	<20141114100939.GB30599@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141114100939.GB30599@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: zhigang.x.wang@oracle.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2014-11-14 at 10:09 +0000, Wei Liu wrote:
> On Fri, Nov 14, 2014 at 09:59:00AM +0000, Ian Campbell wrote:
> > On Wed, 2014-11-12 at 17:04 +0000, Wei Liu wrote:
> > > Unconditionally print out the partial configuration.
> > 
> > Can you provide an example of what such a configuration looks like?
> > 
> 
>     {
>         "domid": 2,
>         "config": {
>             "c_info": {
>                 "name": "s0-raw-vnuma",
>                 "uuid": "a8bed4ac-a0fe-4166-8eac-feeb007a2110"
>             },
>             "b_info": {
>                 "sched_params": {
> 
>                 },
>                 "type.invalid": {
> 
>                 }
>             }
>         }
>     }

Great, thanks. I propose to insert this into the commit message as I
check it in (once I check who's acked it etc)

> Libxl still complains because it tries to read some nodes that don't
> exist, so xl will just print it out on stderr. This is the same
> behaviour as before though.

I think that's tolerable for 4.5 at least.

Ian.