From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for-4.5] libxl: add missing action in
 DEFINE_DEVICE_ADD
Date: Fri, 14 Nov 2014 10:40:04 +0000
Message-ID: <1415961604.21321.40.camel@citrix.com>
References: <1415788771-16563-1-git-send-email-wei.liu2@citrix.com>
	<1415789784.25176.67.camel@citrix.com>
	<1415961333.21321.35.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1415961333.21321.35.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2014-11-14 at 10:35 +0000, Ian Campbell wrote:
> On Wed, 2014-11-12 at 10:56 +0000, Ian Campbell wrote:
> > On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote:
> > > ... otherwise when device add operation fails, the error message looks
> > > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
> > > device", which is not very helpful.
> > 
> > Thanks.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Konrad, in v1 Wei said "This is a simple enough bug fix I think it
> should just go in." and I agree.

Nevermind I've just seen the ack which was in the wrong folder here. 

> 
> > 
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > ---
> > >  tools/libxl/libxl.c |    1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > > index f7961f6..de23fec 100644
> > > --- a/tools/libxl/libxl.c
> > > +++ b/tools/libxl/libxl.c
> > > @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
> > >                                                                          \
> > >          GCNEW(aodev);                                                   \
> > >          libxl__prepare_ao_device(ao, aodev);                            \
> > > +        aodev->action = LIBXL__DEVICE_ACTION_ADD;                       \
> > >          aodev->callback = device_addrm_aocomplete;                      \
> > >          aodev->update_json = true;                                      \
> > >          libxl__device_##type##_add(egc, domid, type, aodev);            \
> > 
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel