From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for-4.5 2/2] xl: print out partial
 configuration in long mode of list command
Date: Fri, 14 Nov 2014 10:53:45 +0000
Message-ID: <1415962425.7113.3.camel@citrix.com>
References: <1415811865-19981-1-git-send-email-wei.liu2@citrix.com>
	<1415811865-19981-3-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1415811865-19981-3-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: zhigang.x.wang@oracle.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-11-12 at 17:04 +0000, Wei Liu wrote:
> Unconditionally print out the partial configuration.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Zhigang Wang <zhigang.x.wang@oracle.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
>  tools/libxl/xl_cmdimpl.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 3c9f146..396e06c 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3388,7 +3388,7 @@ static void list_domains_details(const libxl_dominfo *info, int nb_domain)
>  {
>      libxl_domain_config d_config;
>  
> -    int i, rc;
> +    int i;
>  
>      yajl_gen hand = NULL;
>      yajl_gen_status s;
> @@ -3410,9 +3410,7 @@ static void list_domains_details(const libxl_dominfo *info, int nb_domain)
>  
>      for (i = 0; i < nb_domain; i++) {
>          libxl_domain_config_init(&d_config);
> -        rc = libxl_retrieve_domain_configuration(ctx, info[i].domid, &d_config);
> -        if (rc)
> -            continue;
> +        libxl_retrieve_domain_configuration(ctx, info[i].domid, &d_config);

Should't this continue to skip cases where rc is not in {0,
ERROR_EMPTY_JSON}?

Ian.