From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD Date: Fri, 14 Nov 2014 10:57:01 +0000 Message-ID: <1415962621.7113.5.camel@citrix.com> References: <1415788771-16563-1-git-send-email-wei.liu2@citrix.com> <1415789784.25176.67.camel@citrix.com> <20141112151624.GB6017@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141112151624.GB6017@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Ian Jackson , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-11-12 at 10:16 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 12, 2014 at 10:56:24AM +0000, Ian Campbell wrote: > > On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote: > > > ... otherwise when device add operation fails, the error message looks > > > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null) > > > device", which is not very helpful. > > > > Thanks. > > > > > > Signed-off-by: Wei Liu > > > > Acked-by: Ian Campbell > > Release-Acked-by: Konrad Rzeszutek Wilk Applied, thanks.