From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH ARM v8 2/4] mini-os: arm: interrupt controller Date: Fri, 14 Nov 2014 11:42:33 +0000 Message-ID: <1415965353.7113.16.camel@citrix.com> References: <1412328051-20015-1-git-send-email-talex5@gmail.com> <1412328051-20015-3-git-send-email-talex5@gmail.com> <1413889218.23337.24.camel@citrix.com> <20141021215406.GJ3481@type.youpi.perso.aquilenet.fr> <1413968619.20604.56.camel@citrix.com> <5447ABE4.1030703@linaro.org> <544FB580.7080809@linaro.org> <544FBB76.7050102@linaro.org> <5465E89C.1030701@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XpFHQ-0002rP-3l for xen-devel@lists.xenproject.org; Fri, 14 Nov 2014 11:43:08 +0000 In-Reply-To: <5465E89C.1030701@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Thomas Leonard , David Scott , Anil Madhavapeddy , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Samuel Thibault List-Id: xen-devel@lists.xenproject.org On Fri, 2014-11-14 at 11:33 +0000, Julien Grall wrote: > >> Though IIRC, mini-os for ARM is not yet SMP. > > > > It's difficult to see what needs to be done to support code that > > doesn't exist yet. For example, would gic_init be called once, or once > > per processor? Before or after the other processors are started? > > Some part of the code maybe necessary: setting PPIs/SGIs... You can give > a look to Linux/Xen GIC drivers to have an idea on what is necessary. This would be necessary as part of the port of mini-os to support SMP. I don't see why it should be necessary now, going to SMP is surely going to require a bunch of refactoring in other places too (Xen itself certainly did). Ian.