All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <jkrause@posteo.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/dnsmasq: cleanup run-time files in init script
Date: Sat, 15 Nov 2014 15:05:35 +0100	[thread overview]
Message-ID: <1416060335.2386.5.camel@posteo.de> (raw)
In-Reply-To: <1416057928.2386.2.camel@posteo.de>

On Sa, 2014-11-15 at 14:25 +0100, J?rg Krause wrote:
> On Fr, 2014-11-14 at 23:47 +0100, Arnout Vandecappelle wrote:
> > On 14/11/14 22:30, J?rg Krause wrote:
> > > dnsmasq does not clean its run-times its run-time files after stopping with
> > > /etc/init.d/S80dnsmasq stop. Do this manually.
> > > 
> > > Signed-off-by: J?rg Krause <jkrause@posteo.de>
> > > ---
> > >  package/dnsmasq/S80dnsmasq | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/package/dnsmasq/S80dnsmasq b/package/dnsmasq/S80dnsmasq
> > > index 587751e..b29fff4 100755
> > > --- a/package/dnsmasq/S80dnsmasq
> > > +++ b/package/dnsmasq/S80dnsmasq
> > > @@ -13,6 +13,9 @@ case "$1" in
> > >  		echo -n "Stopping dnsmasq: "
> > >  		start-stop-daemon -K -q -x /usr/sbin/dnsmasq
> > >  		[ $? = 0 ] && echo "OK" || echo "FAIL"
> > > +		# dnsmasq does not clean its run-time files
> > > +		rm -f /var/run/dnsmasq.pid
> > > +		rm -f /var/run/dnsmasq.leases
> > 
> >  The leases file is read again by dnsmasq when it starts, so it can give the
> > same addresses. So it shouldn't be removed. In fact, in my setup I even put the
> > leases file in persistent storage.
> 
> For any reason dnsmasq duplicates the leases file. I have a copy
> in /var/lib/misc/ and one in /var/run/. Not sure why the latter one
> exists.

Ouch! /var/run and /var/lib/misc both symlinks to /tmp. That's why! So I
will remove the removing of the leases file.

      reply	other threads:[~2014-11-15 14:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 21:30 [Buildroot] [PATCH 1/1] package/dnsmasq: cleanup run-time files in init script Jörg Krause
2014-11-14 22:47 ` Arnout Vandecappelle
2014-11-15 13:25   ` Jörg Krause
2014-11-15 14:05     ` Jörg Krause [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416060335.2386.5.camel@posteo.de \
    --to=jkrause@posteo.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.