From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: [PATCH net-next] netdevice: Neaten includes and forward declarations
Date: Sun, 16 Nov 2014 14:21:31 -0800 [thread overview]
Message-ID: <1416176491.24600.3.camel@perches.com> (raw)
In-Reply-To: <20141116.154923.1364136096942964102.davem@davemloft.net>
Use the appropriate #include path for neighbour.h and
add device.h which was indirectly #included by dmaengine.h
Remove unnecessary forward declaration of struct device;
Add comments for other forward struct declarations.
Signed-off-by: Joe Perches <joe@perches.com>
---
include/linux/netdevice.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index fa6bd7d..33ce566 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -36,6 +36,7 @@
#include <linux/percpu.h>
#include <linux/rculist.h>
+#include <linux/device.h>
#include <linux/dmaengine.h>
#include <linux/workqueue.h>
#include <linux/dynamic_queue_limits.h>
@@ -49,16 +50,15 @@
#include <net/netprio_cgroup.h>
#include <linux/netdev_features.h>
-#include <linux/neighbour.h>
+
+#include <uapi/linux/neighbour.h>
#include <uapi/linux/netdevice.h>
-struct netpoll_info;
-struct device;
-struct phy_device;
-/* 802.11 specific */
-struct wireless_dev;
-/* 802.15.4 specific */
-struct wpan_dev;
+/* forward struct type declarations */
+struct netpoll_info; /* for net_device_ops */
+struct phy_device; /* for net_device */
+struct wireless_dev; /* for net_device: 802.11 specific */
+struct wpan_dev; /* for net_device: 802.15.4 specific */
void netdev_set_default_ethtool_ops(struct net_device *dev,
const struct ethtool_ops *ops);
next prev parent reply other threads:[~2014-11-16 22:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 6:08 [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2014-11-14 Jeff Kirsher
2014-11-15 6:08 ` [net-next 01/12] i40e: only warn once of PTP nonsupport in 100Mbit speed Jeff Kirsher
2014-11-15 21:20 ` Florian Fainelli
2014-11-15 22:38 ` [PATCH net-next] device: Add dev_<level>_once variants Joe Perches
2014-11-16 20:49 ` David Miller
2014-11-16 22:21 ` Joe Perches [this message]
2014-11-18 20:48 ` [PATCH net-next] netdevice: Neaten includes and forward declarations David Miller
2014-11-18 21:09 ` Joe Perches
2014-11-18 21:21 ` David Miller
2014-11-16 22:12 ` [PATCH net-next] i40e: Reduce stack in i40e_dbg_dump_desc Joe Perches
2014-11-17 21:06 ` David Miller
2014-11-17 21:30 ` Jeff Kirsher
2014-11-18 2:18 ` [PATCH (sent originally to netdev)] device: Add dev_<level>_once variants Joe Perches
2014-11-18 2:23 ` Jeff Kirsher
2014-11-15 6:08 ` [net-next 02/12] i40e: re-enable VFLR interrupt sooner Jeff Kirsher
2014-11-15 6:08 ` [net-next 03/12] i40e: Handle a single mss packet with more than 8 frags Jeff Kirsher
2014-11-15 18:21 ` Eric Dumazet
2014-11-17 14:15 ` David Laight
2014-11-17 14:31 ` Eric Dumazet
2014-11-17 14:40 ` David Laight
2014-11-17 14:55 ` Eric Dumazet
2014-11-17 16:04 ` Nelson, Shannon
2014-11-17 16:16 ` David Laight
2014-11-17 16:52 ` Eric Dumazet
2014-11-17 16:58 ` Eric Dumazet
2014-11-17 17:09 ` Eric Dumazet
2014-11-18 9:46 ` David Laight
2014-11-18 14:33 ` Eric Dumazet
2014-11-17 16:45 ` Eric Dumazet
2014-11-15 6:08 ` [net-next 04/12] i40e: Bump version to 1.1.23 Jeff Kirsher
2014-11-15 6:08 ` [net-next 05/12] i40e: Resume Port Tx after DCB event Jeff Kirsher
2014-11-15 6:08 ` [net-next 06/12] i40e: Add support to firmware CEE DCBX mode Jeff Kirsher
2014-11-15 6:08 ` [net-next 07/12] i40e: Check for LLDP AdminStatus before querying DCBX Jeff Kirsher
2014-11-15 6:08 ` [net-next 08/12] i40e: Update VEB's enabled_tc after reconfiguration Jeff Kirsher
2014-11-15 6:08 ` [net-next 09/12] i40e: Modify Tx disable wait flow in case of DCB reconfiguration Jeff Kirsher
2014-11-15 6:08 ` [net-next 10/12] i40e: Do not disable/enable FCoE VSI with DCB reconfig Jeff Kirsher
2014-11-15 6:08 ` [net-next 11/12] i40e: Prevent link flow control settings when PFC is enabled Jeff Kirsher
2014-11-15 6:08 ` [net-next 12/12] i40e: Set XPS bit mask to zero in DCB mode Jeff Kirsher
2014-11-16 20:04 ` [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2014-11-14 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416176491.24600.3.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.