From: Jun Li <junmuzi@gmail.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, juli@redhat.com, kraxel@redhat.com,
Jun Li <junmuzi@gmail.com>
Subject: [Qemu-devel] [PATCH] usb: delete error_report() for usb-bot
Date: Mon, 17 Nov 2014 13:49:35 +0800 [thread overview]
Message-ID: <1416203375-8185-1-git-send-email-junmuzi@gmail.com> (raw)
When no device under usb-bot bus, usb_msd_handle_data() will print "usb-msd: Bad
LUN 0". This is not correct hints. So delete error_report here. When
scsi_device_find() return NULL, just goto fail.
This patch fixes following bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1164665
Signed-off-by: Jun Li <junmuzi@gmail.com>
---
hw/usb/dev-storage.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 4539733..f386d62 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -424,7 +424,6 @@ static void usb_msd_handle_data(USBDevice *dev, USBPacket *p)
DPRINTF("Command on LUN %d\n", cbw.lun);
scsi_dev = scsi_device_find(&s->bus, 0, 0, cbw.lun);
if (scsi_dev == NULL) {
- error_report("usb-msd: Bad LUN %d", cbw.lun);
goto fail;
}
tag = le32_to_cpu(cbw.tag);
--
1.9.3
next reply other threads:[~2014-11-17 5:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 5:49 Jun Li [this message]
2014-11-17 6:25 ` [Qemu-devel] [PATCH] usb: delete error_report() for usb-bot Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416203375-8185-1-git-send-email-junmuzi@gmail.com \
--to=junmuzi@gmail.com \
--cc=famz@redhat.com \
--cc=juli@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.