From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] fix rename: xenstore not fully updated Date: Mon, 17 Nov 2014 10:25:31 +0000 Message-ID: <1416219931.27385.17.camel@citrix.com> References: <1416215987-21571-1-git-send-email-cyliu@suse.com> <20141117095254.GG11070@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141117095254.GG11070@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, Chunyan Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2014-11-17 at 09:52 +0000, Wei Liu wrote: > > + /* update backend /local/domain/0/backend///.../domain */ > > + be_dev = libxl__xs_directory(gc, trans, "/local/domain/0/backend", &ndevs); > > The hard-coded 0 cannot work if you have driver domain. > > At the very least it should be using LIBXL_TOOLSTACK_DOMID. Does anyone know the purpose of this node, i.e. what consumes it? docs/misc/xenstore-paths.markdown doesn't mention it, neither do any of xen/include/public/io/*.h AFAICS. The backend needing to know the name (as opposed to domid) of the frontend domain seems rather unusual to me. Perhaps we should just nuke this key? Ian.