From: Ian Campbell <ijc@hellion.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] dt-bindings: simplefb-sunxi: Add sunxi simplefb extensions
Date: Mon, 17 Nov 2014 12:22:34 +0000 [thread overview]
Message-ID: <1416226954.5466.8.camel@hellion.org.uk> (raw)
In-Reply-To: <1416224086-5698-3-git-send-email-hdegoede@redhat.com>
On Mon, 2014-11-17 at 12:34 +0100, Hans de Goede wrote:
> +- sunxi,pipeline:
> + <0> for the de_be0 -> lcdc0 -> output pipeline
> + <1> for the de_be1 -> lcdc1 -> output pipeline
Can we express this as a more descriptive string rather than a number,
to better handle future developments?
Otherwise both patches in this series look good to me.
> +- sunxi,output: One of: "hdmi", "lcd", "vga", and "composite"
> +
> +Example:
> +
> +chosen {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + framebuffer@0 {
> + compatible = "sunxi,framebuffer", "simple-framebuffer";
> + sunxi,pipeline = <0>;
> + sunxi,output = "hdmi";
> + clocks = <&pll5 1>, <&ahb_gates 36>, <&ahb_gates 43>,
> + <&ahb_gates 44>;
> + status = "disabled";
> + };
> +};
WARNING: multiple messages have this Message-ID (diff)
From: ijc@hellion.org.uk (Ian Campbell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] dt-bindings: simplefb-sunxi: Add sunxi simplefb extensions
Date: Mon, 17 Nov 2014 12:22:34 +0000 [thread overview]
Message-ID: <1416226954.5466.8.camel@hellion.org.uk> (raw)
In-Reply-To: <1416224086-5698-3-git-send-email-hdegoede@redhat.com>
On Mon, 2014-11-17 at 12:34 +0100, Hans de Goede wrote:
> +- sunxi,pipeline:
> + <0> for the de_be0 -> lcdc0 -> output pipeline
> + <1> for the de_be1 -> lcdc1 -> output pipeline
Can we express this as a more descriptive string rather than a number,
to better handle future developments?
Otherwise both patches in this series look good to me.
> +- sunxi,output: One of: "hdmi", "lcd", "vga", and "composite"
> +
> +Example:
> +
> +chosen {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + framebuffer at 0 {
> + compatible = "sunxi,framebuffer", "simple-framebuffer";
> + sunxi,pipeline = <0>;
> + sunxi,output = "hdmi";
> + clocks = <&pll5 1>, <&ahb_gates 36>, <&ahb_gates 43>,
> + <&ahb_gates 44>;
> + status = "disabled";
> + };
> +};
WARNING: multiple messages have this Message-ID (diff)
From: Ian Campbell <ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
David Herrmann
<dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 2/2] dt-bindings: simplefb-sunxi: Add sunxi simplefb extensions
Date: Mon, 17 Nov 2014 12:22:34 +0000 [thread overview]
Message-ID: <1416226954.5466.8.camel@hellion.org.uk> (raw)
In-Reply-To: <1416224086-5698-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Mon, 2014-11-17 at 12:34 +0100, Hans de Goede wrote:
> +- sunxi,pipeline:
> + <0> for the de_be0 -> lcdc0 -> output pipeline
> + <1> for the de_be1 -> lcdc1 -> output pipeline
Can we express this as a more descriptive string rather than a number,
to better handle future developments?
Otherwise both patches in this series look good to me.
> +- sunxi,output: One of: "hdmi", "lcd", "vga", and "composite"
> +
> +Example:
> +
> +chosen {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + framebuffer@0 {
> + compatible = "sunxi,framebuffer", "simple-framebuffer";
> + sunxi,pipeline = <0>;
> + sunxi,output = "hdmi";
> + clocks = <&pll5 1>, <&ahb_gates 36>, <&ahb_gates 43>,
> + <&ahb_gates 44>;
> + status = "disabled";
> + };
> +};
next prev parent reply other threads:[~2014-11-17 12:22 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 11:34 [PATCH 0/2] dt-bindings: simplefb: Drop the advice about using a specific path for nodes Hans de Goede
2014-11-17 11:34 ` Hans de Goede
2014-11-17 11:34 ` Hans de Goede
2014-11-17 11:34 ` [PATCH 1/2] " Hans de Goede
2014-11-17 11:34 ` Hans de Goede
2014-11-17 11:34 ` Hans de Goede
2014-11-17 12:18 ` Grant Likely
2014-11-17 12:18 ` Grant Likely
2014-11-17 12:18 ` Grant Likely
2014-11-17 11:34 ` [PATCH 2/2] dt-bindings: simplefb-sunxi: Add sunxi simplefb extensions Hans de Goede
2014-11-17 11:34 ` Hans de Goede
2014-11-17 11:34 ` Hans de Goede
2014-11-17 12:18 ` Grant Likely
2014-11-17 12:18 ` Grant Likely
2014-11-17 12:18 ` Grant Likely
2014-11-17 12:22 ` Ian Campbell [this message]
2014-11-17 12:22 ` Ian Campbell
2014-11-17 12:22 ` Ian Campbell
2014-11-17 12:47 ` Maxime Ripard
2014-11-17 12:47 ` Maxime Ripard
2014-11-17 12:47 ` Maxime Ripard
2014-11-17 13:07 ` Hans de Goede
2014-11-17 13:07 ` Hans de Goede
2014-11-17 13:07 ` Hans de Goede
2014-11-17 13:39 ` Grant Likely
2014-11-17 13:39 ` Grant Likely
2014-11-17 13:39 ` Grant Likely
2014-11-17 15:55 ` Maxime Ripard
2014-11-17 15:55 ` Maxime Ripard
2014-11-17 15:55 ` Maxime Ripard
2014-11-18 8:15 ` Hans de Goede
2014-11-18 8:15 ` Hans de Goede
2014-11-18 8:15 ` Hans de Goede
2014-11-18 8:47 ` Ian Campbell
2014-11-18 8:47 ` Ian Campbell
2014-11-18 8:47 ` Ian Campbell
2014-11-18 9:09 ` Hans de Goede
2014-11-18 9:09 ` Hans de Goede
2014-11-18 9:09 ` Hans de Goede
2014-11-18 9:29 ` Maxime Ripard
2014-11-18 9:29 ` Maxime Ripard
2014-11-18 9:29 ` Maxime Ripard
2014-11-19 14:05 ` Grant Likely
2014-11-19 14:05 ` Grant Likely
2014-11-19 14:05 ` Grant Likely
2014-11-21 14:36 ` Maxime Ripard
2014-11-21 14:36 ` Maxime Ripard
2014-11-21 14:36 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416226954.5466.8.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.