From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix 11b fragmentation rx
Date: Mon, 17 Nov 2014 13:29:06 +0100 [thread overview]
Message-ID: <1416227346.2031.3.camel@sipsolutions.net> (raw)
In-Reply-To: <1416223626-10980-1-git-send-email-michal.kazior@tieto.com> (sfid-20141117_123935_571471_5D6961B2)
On Mon, 2014-11-17 at 12:27 +0100, Michal Kazior wrote:
> After fragmentation reassembly was complete code
> tried to dereference hdr pointer which pointed to
> data of an sk_buff that has been freed.
Curious. This bug has been around forever (since the introduction of
mac80211). I wonder what changed that you *also* found it now - because
we also found it recently!
> --- a/net/mac80211/rx.c
> +++ b/net/mac80211/rx.c
> @@ -1854,6 +1854,7 @@ ieee80211_rx_h_defragment(struct ieee80211_rx_data *rx)
> /* Complete frame has been reassembled - process it now */
> status = IEEE80211_SKB_RXCB(rx->skb);
> status->rx_flags |= IEEE80211_RX_FRAGMENTED;
> + hdr = (struct ieee80211_hdr *)rx->skb->data;
This is technically correct, but useless. I already have this patch in
my tree instead:
https://git.kernel.org/cgit/linux/kernel/git/jberg/mac80211.git/commit/?id=b8fff407a180286aa683d543d878d98d9fc57b13
johannes
next prev parent reply other threads:[~2014-11-17 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 11:27 [PATCH] mac80211: fix 11b fragmentation rx Michal Kazior
2014-11-17 12:29 ` Johannes Berg [this message]
2014-11-17 13:07 ` Michal Kazior
2014-11-17 13:20 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416227346.2031.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.