From: Imre Deak <imre.deak@intel.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/8] sanitize RPS interrupt enabling/disabling
Date: Tue, 18 Nov 2014 18:08:21 +0200 [thread overview]
Message-ID: <1416326901.4495.1.camel@intelbox> (raw)
In-Reply-To: <CA+gsUGSj8aBLMtwkABHOJOpnoTLZRxV1O5+iOdNEKgNhHseJyA@mail.gmail.com>
On Tue, 2014-11-18 at 14:04 -0200, Paulo Zanoni wrote:
> 2014-11-05 16:48 GMT-02:00 Imre Deak <imre.deak@intel.com>:
> > While fixing [1] I noticed that we can simplify a couple of things in
> > the RPS enabling/disabling code. So I did that and also fixed one WARN
> > that we can hit with some of the pm_rpm subtests. Hopefully these
> > changes also makes it clearer how we avoid the race during RPS interrupt
> > disabling and makes it less fragile (see the comment in patch 7/8).
> >
> > [1] https://bugs.freedesktop.org/show_bug.cgi?id=82939
> >
> > Imre Deak (8):
> > drm/i915: unify gen6/gen8 pm irq helpers
> > drm/i915: unify gen6/gen8 rps irq handler
> > drm/i915: unify gen6/gen8 rps irq enable/disable
> > drm/i915: move rps irq enable/disable to i915_irq.c
> > drm/i915: move rps irq disable one level up
> > drm/i915: sanitize rps irq enabling
> > drm/i915: sanitize rps irq disabling
> > drm/i915: disable rps irqs earlier during suspend/unload
>
> With or without my bikesheds, feel free to add "Reviewed-by: Paulo
> Zanoni <paulo.r.zanoni@intel.com>" to:
> - new versions of patches 5, 6, and 7
> - patch 8
Thanks!
> Although it would be nice to see those "gen != 9" replaced with "gen <
> 9", but maybe Daniel can do this.
Ok, will resend with those changes.
> > drivers/gpu/drm/i915/i915_drv.c | 9 +--
> > drivers/gpu/drm/i915/i915_drv.h | 6 +-
> > drivers/gpu/drm/i915/i915_irq.c | 122 +++++++++++++++++++----------------
> > drivers/gpu/drm/i915/intel_display.c | 6 +-
> > drivers/gpu/drm/i915/intel_drv.h | 5 +-
> > drivers/gpu/drm/i915/intel_pm.c | 90 +++-----------------------
> > 6 files changed, 90 insertions(+), 148 deletions(-)
> >
> > --
> > 1.8.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-18 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 18:48 [PATCH 0/8] sanitize RPS interrupt enabling/disabling Imre Deak
2014-11-07 20:42 ` Paulo Zanoni
2014-11-08 12:57 ` Imre Deak
2014-11-11 10:29 ` Daniel Vetter
2014-11-18 16:04 ` Paulo Zanoni
2014-11-18 16:08 ` Imre Deak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416326901.4495.1.camel@intelbox \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.