From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5 4/4] xen: arm: Support the other 4 PCI buses on Xgene Date: Wed, 19 Nov 2014 10:18:18 +0000 Message-ID: <1416392298.29243.18.camel@citrix.com> References: <1416329045.17982.27.camel@citrix.com> <1416329088-23328-4-git-send-email-ian.campbell@citrix.com> <546B7E9E.9040806@linaro.org> <1416390980.29243.12.camel@citrix.com> <546C6BA3.1050202@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <546C6BA3.1050202@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Clark Laughlin , Pranavkumar Sawargaonkar , tim@xen.org, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-11-19 at 10:06 +0000, Julien Grall wrote: > Hi Ian, > > On 19/11/2014 09:56, Ian Campbell wrote: > > On Tue, 2014-11-18 at 17:15 +0000, Julien Grall wrote: > >>> + default: > >>> + /* Ignore unknown PCI busses */ > >> > >> I would add a > >> printk("Ignoring PCI busses %s\n", dt_node_full_name(dev)); > >> > >>> + ret = 0; > >>> + break; > >> > >> continue? > > > > Yes, that makes sense (probably the ret = is then unnecessary). > > > >> You can't assume the order of the PCI busses in the device tree. > > > > But, I don't understand what this has to do with using continue. > > The current xgene-storm DTS has the different PCI busses ordered. So as > soon as you don't find the PCI range, it means there is no more PCI busses. I don't think it does, the patch iterates over all of the buses, even ones we don't understand, we don't give up at the first one we don't grok. > Without the continue, this patch gives the impression that you rely on > the node order on the device tree. > > Regards, >