From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/6] mac80211: add ieee80211_tx_status_noskb
Date: Wed, 19 Nov 2014 19:55:09 +0100 [thread overview]
Message-ID: <1416423309.9374.25.camel@sipsolutions.net> (raw)
In-Reply-To: <546CE5B3.6080005@openwrt.org>
On Wed, 2014-11-19 at 19:47 +0100, Felix Fietkau wrote:
> >> + * This function may not be called in IRQ context. Calls to this function
> >> + * for a single hardware must be synchronized against each other. Calls
> >> + * to this function, ieee80211_tx_status_ni() and ieee80211_tx_status_irqsafe()
> >> + * may not be mixed for a single hardware. Must not run concurrently with
> >> + * ieee80211_rx() or ieee80211_rx_ni().
> >
> > None of that seems very likely. Did you just copy/paste it? :)
> Yes, I copy/pasted it. I wasn't sure if these requirements would be
> necessary for the no-skb status as well, just figured it'd be safe to
> leave them in.
I think if you move the eosp() that leaves you pretty much with only
things that are safe?
johannes
next prev parent reply other threads:[~2014-11-19 18:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 23:27 [PATCH 1/6] mac80211: minstrel_ht: add a small optimization to minstrel_aggr_check Felix Fietkau
2014-11-15 23:27 ` [PATCH 2/6] mac80211: minstrel_ht: move aggregation check to .get_rate() Felix Fietkau
2014-11-19 18:34 ` Johannes Berg
2014-11-15 23:27 ` [PATCH 3/6] mac80211: add tx_status_noskb to rate_control_ops Felix Fietkau
2014-11-19 18:35 ` Johannes Berg
2014-11-15 23:27 ` [PATCH 4/6] mac80211: minstrel: switch to .tx_status_noskb Felix Fietkau
2014-11-15 23:27 ` [PATCH 5/6] mac80211: minstrel_ht: " Felix Fietkau
2014-11-15 23:28 ` [PATCH 6/6] mac80211: add ieee80211_tx_status_noskb Felix Fietkau
2014-11-19 18:38 ` Johannes Berg
2014-11-19 18:47 ` Felix Fietkau
2014-11-19 18:55 ` Johannes Berg [this message]
2014-11-19 18:34 ` [PATCH 1/6] mac80211: minstrel_ht: add a small optimization to minstrel_aggr_check Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416423309.9374.25.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.