From: Johannes Berg <johannes@sipsolutions.net>
To: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v6] nl80211: Stop scheduled scan if netlink client disappears
Date: Thu, 20 Nov 2014 16:14:16 +0100 [thread overview]
Message-ID: <1416496456.8557.2.camel@sipsolutions.net> (raw)
In-Reply-To: <1416483178-5528-1-git-send-email-jukka.rissanen@linux.intel.com> (sfid-20141120_123314_318179_38B7117E)
On Thu, 2014-11-20 at 13:32 +0200, Jukka Rissanen wrote:
> - moved owner netlink port id from cfg80211_sched_scan_request to
> rdev in order to avoid possible races
How does that really help though? You're not really locking it anyway.
I think you should consider keeping it inside the sched_scan_request,
but maybe make that an __rcu pointer.
Your patch also still has the problem I pointed out to you before - you
can get the following sequence of events:
start_sched_scan (owner=true)
close socket - schedule worker
start_sched_scan (from another socket, owner doesn't matter)
run worker - cancels the new sched_scan
You need to make sure the worker is flushed in start_sched_scan or so,
which might require RTNL work there or something.
johannes
next prev parent reply other threads:[~2014-11-20 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 11:32 [PATCH v6] nl80211: Stop scheduled scan if netlink client disappears Jukka Rissanen
2014-11-20 15:14 ` Johannes Berg [this message]
2014-11-21 8:00 ` Jukka Rissanen
2014-11-21 9:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416496456.8557.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.