From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] libxl: Document device parameter of libxl_device__add functions Date: Thu, 20 Nov 2014 15:57:58 +0000 Message-ID: <1416499078.14429.34.camel@citrix.com> References: <1416330461-11985-1-git-send-email-euan.harris@citrix.com> <21611.34164.318838.773459@mariner.uk.xensource.com> <20141118181927.GA24283@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141118181927.GA24283@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Euan Harris , Wei Liu , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2014-11-18 at 13:19 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Nov 18, 2014 at 05:44:20PM +0000, Ian Jackson wrote: > > Euan Harris writes ("[PATCH] libxl: Document device parameter of libxl_device__add functions"): > > > The device parameter of libxl_device__add is an in/out parameter. > > > Unspecified fields are filled in with appropriate values for the created > > > device when the function returns. Document this behaviour. > > > > Thanks. > > > > Acked-by: Ian Jackson > > > > Konrad, this should go into 4.5 IMO because it's a doc comment > > describing existing behaviour which we want everyone to rely on. > > Release-Acked-by: Konrad Rzeszutek Wilk and applied, thanks all.