From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] mkdeb: correctly map package architectures for x86 and ARM Date: Thu, 20 Nov 2014 15:58:07 +0000 Message-ID: <1416499087.14429.35.camel@citrix.com> References: <1415806728-28484-1-git-send-email-clark.laughlin@linaro.org> <1415807026.1155.21.camel@citrix.com> <1415959858.21321.23.camel@citrix.com> <20141119194515.GB18117@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XrU7b-0005YO-7e for xen-devel@lists.xenproject.org; Thu, 20 Nov 2014 15:58:15 +0000 In-Reply-To: <20141119194515.GB18117@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Ian Jackson , Tim Deegan , Clark Laughlin , Wei Liu , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, 2014-11-19 at 14:45 -0500, Konrad Rzeszutek Wilk wrote: > On Fri, Nov 14, 2014 at 10:10:58AM +0000, Ian Campbell wrote: > > (CCing some more maintainers and the release manager) > > > > On Wed, 2014-11-12 at 15:43 +0000, Ian Campbell wrote: > > > On Wed, 2014-11-12 at 09:38 -0600, Clark Laughlin wrote: > > > > mkdeb previously set the package architecture to be 'amd64' for anything other than > > > > XEN_TARGET_ARCH=x86_32. This patch attempts to correctly map the architecture from > > > > GNU names to debian names for x86 and ARM architectures, or otherwise, defaults it > > > > to the value in XEN_TARGET_ARCH. > > > > > > > > Signed-off-by: Clark Laughlin > > > > > > Acked-by: Ian Campbell > > > > Actually thinking about it some more I'd be happier arguing for a freeze > > exception for something like the below which only handles the actual > > valid values of XEN_TARGET_ARCH and not the GNU names (which cannot > > happen) and prints an error for unknown architectures (so new ports > > aren't bitten in the future, etc). > > > > Konrad, wrt the freeze I think this is low risk for breaking x86 > > platforms and makes things work for arm, so is worth it. > > Release-Acked-by: Konrad Rzeszutek Wilk Ian J acked on IRC, so I've applied, thanks.