Re: [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers

[Ian Campbell <Ian.Campbell@citrix.com>]

On Thu, 2014-11-20 at 16:21 +0000, Julien Grall wrote:
> On 11/20/2014 04:15 PM, Julien Grall wrote:
> > Hi Ian,
> > 
> > On 11/20/2014 04:08 PM, Ian Campbell wrote:
> >> On Tue, 2014-11-18 at 20:03 +0000, Julien Grall wrote:
> >>> By default, the script get_maintainer.pl will remove duplicates email as soon
> >>> as it appends the list of maintainers of a new file, and therefore override
> >>> the role of the developper.
> >>>
> >>> On complex patch (see [1]), this will result to ommitting randomly some
> >>> maintainers.
> >>>
> >>> This could be fixed
> >>
> >> Are you proposing an alternative/better fix here? or describing what
> >> this patch does?
> > 
> > Describing what the patch does.
> > 
> >>>  by not removing the duplicate email in the list. Once the
> >>> list is created, when it's necessary, the script will drop the "REST" people
> >>> and remove duplicata.
> >>>
> >>> Example:
> >>>
> >>> Patch: https://patches.linaro.org/41083/
> >>>
> >>> Before:
> >>>
> >>> Daniel De Graaf <dgdegra@tycho.nsa.gov>
> >>> Ian Jackson <ian.jackson@eu.citrix.com>
> >>> Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >>> Ian Campbell <ian.campbell@citrix.com>
> >>> Wei Liu <wei.liu2@citrix.com>
> >>> George Dunlap <george.dunlap@eu.citrix.com>
> >>> xen-devel@lists.xen.org
> >>>
> >>> After:
> >>>
> >>> Daniel De Graaf <dgdegra@tycho.nsa.gov>
> >>> Ian Jackson <ian.jackson@eu.citrix.com>
> >>> Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >>> Ian Campbell <ian.campbell@citrix.com>
> >>> Wei Liu <wei.liu2@citrix.com>
> >>> Stefano Stabellini <stefano.stabellini@citrix.com>
> >>> Tim Deegan <tim@xen.org>
> >>> Keir Fraser <keir@xen.org>
> >>> Jan Beulich <jbeulich@suse.com>
> >>> George Dunlap <george.dunlap@eu.citrix.com>
> >>> xen-devel@lists.xen.org
> >>>
> >>> [1] http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00060.html
> >>>
> >>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> >>> CC: Don Slutz <dslutz@verizon.com>
> >>>
> >>> ---
> >>>     I would like to see this patch in Xen 4.5 and backported to Xen 4.4 (first
> >>>     time the script has been introduced).
> >>>
> >>>     Developpers using this script won't ommitted to cc some maintainers, and it
> >>>     will avoid maintainers complaining about miss CC.
> >>>
> >>>     The only drawbacks I can see is there is too much people CCed (the
> >>>     patch d67738db was intended to avoid CCing Keir too often).
> >>
> >> My tree doesn't have in it d67738db but from the example you give above
> >> it seems like this patch will regress that? As someone who already gets
> >> too much mail and is listed in THE REST these days I am very much in
> >> favour of not mailing THE REST when other maintainers have been found.
> 
> Forgot to add, the example above show the difference without and with
> the patch. The list is correct because both ARM and x86 maintainers
> should be CC. Because of this all "THE REST" maintainers are added.

Just to be clear, you mean that everyone under THE REST is added solely
because they also happen to be maintainers of some other relevant bit of
code, not that THE REST is explicitly added in this case, right?

Ian.