From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for-4.5] scripts/get_maintainer.pl:
 Correctly CC the maintainers
Date: Thu, 20 Nov 2014 16:52:02 +0000
Message-ID: <1416502322.20161.9.camel@citrix.com>
References: <1416341031-6204-1-git-send-email-julien.grall@linaro.org>
	<1416499682.14429.41.camel@citrix.com> <546E1389.1070304@linaro.org>
	<546E1526.6090406@linaro.org> <1416500962.20161.4.camel@citrix.com>
	<546E1A18.1040606@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XrUxn-0003AC-3j
	for xen-devel@lists.xenproject.org; Thu, 20 Nov 2014 16:52:11 +0000
In-Reply-To: <546E1A18.1040606@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, Don Slutz <dslutz@verizon.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-11-20 at 16:43 +0000, Julien Grall wrote:
> On 11/20/2014 04:29 PM, Ian Campbell wrote:
> >> Forgot to add, the example above show the difference without and with
> >> the patch. The list is correct because both ARM and x86 maintainers
> >> should be CC. Because of this all "THE REST" maintainers are added.
> > 
> > Just to be clear, you mean that everyone under THE REST is added solely
> > because they also happen to be maintainers of some other relevant bit of
> > code, not that THE REST is explicitly added in this case, right?
> 
> Yes, my description was confusing. With setting $email_remove_duplicates
> to 0, the script will:
>    1) Append the list of maintainers for every file
>    2) Filter the list to remove the entry with "THE REST" role
>    3) Remove duplicated address
> 
> The previous behavior was:
>    1) Get the list of maintainers of the file (incidentally all the
> maintainers in "THE REST" role are added). If the email address already
> exists in the global list, skip it.
>    2) Filter the list to remove the entry with "THE REST" role
> 
> So if a maintainers is marked on the "THE REST" on the first file and
> actually be an x86 maintainers on the second file, the scripts will only
> retain the "THE REST" role.
> 
> If it's more clear, I can add the explanation above in the commit message.

It is, please do.

Ian.